From 95eb8943af63bbf4212f8c6933b35d5ea8b7f341 Mon Sep 17 00:00:00 2001 From: Valere Date: Thu, 2 Apr 2026 19:05:24 +0200 Subject: [PATCH] fixup test: Errors are now wrapped in user readable error and proper fetchmock for doNetworkOperationWithRetry --- src/livekit/openIDSFU.test.ts | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/src/livekit/openIDSFU.test.ts b/src/livekit/openIDSFU.test.ts index 20820748..fc0b6d54 100644 --- a/src/livekit/openIDSFU.test.ts +++ b/src/livekit/openIDSFU.test.ts @@ -19,12 +19,14 @@ import fetchMock from "fetch-mock"; import { getSFUConfigWithOpenID, type OpenIDClientParts } from "./openIDSFU"; import { testJWTToken } from "../utils/test-fixtures"; import { ownMemberMock } from "../utils/test"; +import { FailToGetOpenIdToken } from "../utils/errors"; const sfuUrl = "https://sfu.example.org"; describe("getSFUConfigWithOpenID", () => { let matrixClient: MockedObject; beforeEach(() => { + fetchMock.catch(404); matrixClient = { getOpenIdToken: vitest.fn(), getDeviceId: vitest.fn(), @@ -71,9 +73,10 @@ describe("getSFUConfigWithOpenID", () => { "https://sfu.example.org", "!example_room_id", ); - } catch (ex) { - expect((ex as Error).message).toEqual( - "SFU Config fetch failed with status code 500", + } catch (ex: unknown) { + expect(ex).toBeInstanceOf(FailToGetOpenIdToken); + expect((ex as FailToGetOpenIdToken).cause).toEqual( + new Error("SFU Config fetch failed with status code 500"), ); void (await fetchMock.flush()); return; @@ -106,8 +109,9 @@ describe("getSFUConfigWithOpenID", () => { }, ); } catch (ex) { - expect((ex as Error).message).toEqual( - "SFU Config fetch failed with status code 500", + expect(ex).toBeInstanceOf(FailToGetOpenIdToken); + expect((ex as FailToGetOpenIdToken).cause).toEqual( + new Error("SFU Config fetch failed with status code 500"), ); void (await fetchMock.flush()); } @@ -160,8 +164,9 @@ describe("getSFUConfigWithOpenID", () => { }, ); } catch (ex) { - expect((ex as Error).message).toEqual( - "SFU Config fetch failed with status code 500", + expect(ex).toBeInstanceOf(FailToGetOpenIdToken); + expect((ex as FailToGetOpenIdToken).cause).toEqual( + new Error("SFU Config fetch failed with status code 500"), ); void (await fetchMock.flush()); }