From 97eecfdc54303d75ac47efd8f1227b42664d14a3 Mon Sep 17 00:00:00 2001 From: Timo Date: Tue, 3 Sep 2024 11:56:21 +0200 Subject: [PATCH] es lint fixes --- src/analytics/PosthogSpanProcessor.ts | 2 +- src/home/useGroupCallRooms.ts | 3 +-- src/livekit/useECConnectionState.ts | 1 + src/otel/OTelCallAbstractMediaStreamSpan.ts | 2 +- src/otel/ObjectFlattener.ts | 2 +- src/settings/rageshake.ts | 4 +++- src/settings/settings.ts | 5 ++++- src/settings/submit-rageshake.ts | 16 ++++++++++++---- src/utils/matrix.ts | 4 +++- 9 files changed, 27 insertions(+), 12 deletions(-) diff --git a/src/analytics/PosthogSpanProcessor.ts b/src/analytics/PosthogSpanProcessor.ts index 8904b3e1..59960c92 100644 --- a/src/analytics/PosthogSpanProcessor.ts +++ b/src/analytics/PosthogSpanProcessor.ts @@ -72,7 +72,7 @@ export class PosthogSpanProcessor implements SpanProcessor { try { return JSON.parse(data); } catch (e) { - logger.warn("Invalid prev call data", data); + logger.warn("Invalid prev call data", data, "error:", e); return null; } } diff --git a/src/home/useGroupCallRooms.ts b/src/home/useGroupCallRooms.ts index e4cfa109..4c481543 100644 --- a/src/home/useGroupCallRooms.ts +++ b/src/home/useGroupCallRooms.ts @@ -134,7 +134,7 @@ export function useGroupCallRooms(client: MatrixClient): GroupCallRoom[] { useEffect(() => { function updateRooms(): void { - // We want to show all rooms that historically had a call and which we are (can become) part of. + // We want to show all rooms that historically had a call and which we are (or can become) part of. const rooms = client .getRooms() .filter(roomHasCallMembershipEvents) @@ -142,7 +142,6 @@ export function useGroupCallRooms(client: MatrixClient): GroupCallRoom[] { const sortedRooms = sortRooms(client, rooms); const items = sortedRooms.map((room) => { const session = client.matrixRTC.getRoomSession(room); - session.memberships; return { roomAlias: room.getCanonicalAlias() ?? undefined, roomName: room.name, diff --git a/src/livekit/useECConnectionState.ts b/src/livekit/useECConnectionState.ts index c2bd0aa7..9afb2578 100644 --- a/src/livekit/useECConnectionState.ts +++ b/src/livekit/useECConnectionState.ts @@ -115,6 +115,7 @@ async function doConnect( await connectAndPublish(livekitRoom, sfuConfig, preCreatedAudioTrack, []); } catch (e) { preCreatedAudioTrack?.stop(); + logger.warn("Stopped precreated audio tracks.", e); } } diff --git a/src/otel/OTelCallAbstractMediaStreamSpan.ts b/src/otel/OTelCallAbstractMediaStreamSpan.ts index c34f963c..3ecb6b28 100644 --- a/src/otel/OTelCallAbstractMediaStreamSpan.ts +++ b/src/otel/OTelCallAbstractMediaStreamSpan.ts @@ -67,7 +67,7 @@ export abstract class OTelCallAbstractMediaStreamSpan { }); } - public abstract update(data: Object): void; + public abstract update(data: object): void; public end(): void { this.trackSpans.forEach((tSpan) => { diff --git a/src/otel/ObjectFlattener.ts b/src/otel/ObjectFlattener.ts index 76de9e3a..6c0326bf 100644 --- a/src/otel/ObjectFlattener.ts +++ b/src/otel/ObjectFlattener.ts @@ -74,7 +74,7 @@ export class ObjectFlattener { } public static flattenObjectRecursive( - obj: Object, + obj: object, flatObject: Attributes, prefix: string, depth: number, diff --git a/src/settings/rageshake.ts b/src/settings/rageshake.ts index 0b0365a7..bf6909fb 100644 --- a/src/settings/rageshake.ts +++ b/src/settings/rageshake.ts @@ -505,7 +505,9 @@ function tryInitStorage(): Promise { let indexedDB; try { indexedDB = window.indexedDB; - } catch (e) {} + } catch (e) { + logger.warn("Could not get indexDB from window.", e); + } if (indexedDB) { global.mx_rage_store = new IndexedDBLogStore( diff --git a/src/settings/settings.ts b/src/settings/settings.ts index 9c181ccf..47ca9816 100644 --- a/src/settings/settings.ts +++ b/src/settings/settings.ts @@ -30,7 +30,10 @@ export class Setting { try { initialValue = JSON.parse(storedValue); } catch (e) { - logger.warn(`Invalid value stored for setting ${key}: ${storedValue}`); + logger.warn( + `Invalid value stored for setting ${key}: ${storedValue}.`, + e, + ); } } diff --git a/src/settings/submit-rageshake.ts b/src/settings/submit-rageshake.ts index 3a98b831..adae3f0d 100644 --- a/src/settings/submit-rageshake.ts +++ b/src/settings/submit-rageshake.ts @@ -85,7 +85,9 @@ export function useSubmitRageshake(): { try { // MDN claims broad support across browsers touchInput = String(window.matchMedia("(pointer: coarse)").matches); - } catch (e) {} + } catch (e) { + logger.warn("Could not get coarse pointer for rageshake submit.", e); + } let description = opts.rageshakeRequestId ? `Rageshake ${opts.rageshakeRequestId}` @@ -216,7 +218,9 @@ export function useSubmitRageshake(): { "storageManager_persisted", String(await navigator.storage.persisted()), ); - } catch (e) {} + } catch (e) { + logger.warn("coulr not get navigator peristed storage", e); + } } else if (document.hasStorageAccess) { // Safari try { @@ -224,7 +228,9 @@ export function useSubmitRageshake(): { "storageManager_persisted", String(await document.hasStorageAccess()), ); - } catch (e) {} + } catch (e) { + logger.warn("could not get storage access", e); + } } if (navigator.storage && navigator.storage.estimate) { @@ -244,7 +250,9 @@ export function useSubmitRageshake(): { ); }); } - } catch (e) {} + } catch (e) { + logger.warn("could not obatain storage estimate", e); + } } if (opts.sendLogs) { diff --git a/src/utils/matrix.ts b/src/utils/matrix.ts index f27067bf..936a69e2 100644 --- a/src/utils/matrix.ts +++ b/src/utils/matrix.ts @@ -86,7 +86,9 @@ export async function initClient( let indexedDB: IDBFactory | undefined; try { indexedDB = window.indexedDB; - } catch (e) {} + } catch (e) { + logger.warn("Could not get indexDB from window.", e); + } // options we always pass to the client (stuff that we need in order to work) const baseOpts = {