Matrix/element-call-Github
1
0
Fork 0
mirror of https://github.com/vector-im/element-call.git synced 2026-08-29 21:15:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

Clean up: deduplicate settings UI, fix backupCodec, remove dead export

Browse Source 
Signed-off-by: Ryan Emmick <ryanemmick4@gmail.com>
This commit is contained in:
Ryan Emmick
2026-02-11 12:26:16 -06:00
parent 297470ac2e
commit 98f63c7172
6 changed files with 113 additions and 162 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/state/CallViewModel/localMember/LocalMember.ts
View File

@@ -61,6 +61,7 @@ import {
screenShareFramerate,
screenShareBitrate,
screenShareCodec,
parseResolution,
} from "../../../settings/settings.ts";
import { Config } from "../../../config/Config.ts";
import {
@@ -688,9 +689,7 @@ export const createLocalMembership$ = ({
if (advancedScreenShare.getValue()) {
// User has advanced screen share settings enabled
const resParts = screenShareResolution.getValue().split("x");
const width = Number(resParts[0]);
const height = Number(resParts[1]);
const { width, height } = parseResolution(screenShareResolution.getValue());
const fps = screenShareFramerate.getValue();
const bps = screenShareBitrate.getValue();
const codec = screenShareCodec.getValue();

5
src/state/CallViewModel/remoteMembers/ConnectionFactory.ts
View File

@@ -34,6 +34,7 @@ import {
cameraFramerate,
cameraBitrate,
cameraCodec,
parseResolution,
echoCancellationSetting,
noiseSuppressionSetting,
autoGainControlSetting,
@@ -150,9 +151,7 @@ function generateRoomOption({
let publishDefaults = liveKitOptions.publishDefaults;
if (advancedCamera.getValue()) {
const resParts = cameraResolution.getValue().split("x");
const width = Number(resParts[0]);
const height = Number(resParts[1]);
const { width, height } = parseResolution(cameraResolution.getValue());
const fps = cameraFramerate.getValue();
const bps = cameraBitrate.getValue();
const codec = cameraCodec.getValue();

7
src/state/CallViewModel/remoteMembers/ECConnectionFactory.test.ts
View File

@@ -25,6 +25,7 @@ import { constant } from "../../Behavior";
import {
echoCancellationSetting,
noiseSuppressionSetting,
autoGainControlSetting,
} from "../../../settings/settings.ts";
// At the top of your test file, after imports
@@ -105,9 +106,13 @@ describe("ECConnectionFactory - ControlledAudioDevice", () => {
test.each([{ controlled: true }, { controlled: false }])(
"it sets controlledAudioDevice=$controlled then uses deviceId accordingly",
({ controlled }) => {
// test("it sets echoCancellation and noiseSuppression based on constructor parameters", () => {
const RoomConstructor = vi.mocked(LivekitRoom);
// Explicitly set audio settings so the test doesn't depend on defaults
echoCancellationSetting.setValue(true);
noiseSuppressionSetting.setValue(true);
autoGainControlSetting.setValue(true);
const ecConnectionFactory = new ECConnectionFactory(
mockClient,
"!roomid:example.org",