Refactor raised hand indicator and add tests.

This commit is contained in:
Half-Shot
2024-10-28 12:32:33 +00:00
parent 7f268a3e10
commit a23d256fb6
6 changed files with 162 additions and 70 deletions

View File

@@ -90,46 +90,6 @@ unconditionally select the container so we can use cqmin units */
place-items: start;
}
.raisedHandWidget {
display: flex;
background-color: var(--cpd-color-bg-subtle-primary);
border-radius: var(--cpd-radius-pill-effect);
color: var(--cpd-color-icon-secondary);
border: 1px solid var(--cpd-color-yellow-1200);
}
.raisedHandWidget > p {
padding: var(--cpd-space-2x);
margin-top: auto;
margin-bottom: auto;
width: 4em;
}
.raisedHand {
margin: var(--cpd-space-2x);
padding: var(--cpd-space-2x);
padding-block: var(--cpd-space-2x);
color: var(--cpd-color-icon-secondary);
background-color: var(--cpd-color-icon-secondary);
display: flex;
align-items: center;
border-radius: var(--cpd-radius-pill-effect);
user-select: none;
overflow: hidden;
box-shadow: var(--small-drop-shadow);
box-sizing: border-box;
max-inline-size: 100%;
max-width: fit-content;
}
.raisedHand > span {
width: var(--cpd-space-8x);
height: var(--cpd-space-8x);
display: inline-block;
text-align: center;
font-size: 22px;
}
.raisedHandBorder {
border: var(--cpd-space-1x) solid var(--cpd-color-yellow-1200);
}

View File

@@ -23,6 +23,7 @@ import { ErrorIcon } from "@vector-im/compound-design-tokens/assets/web/icons";
import styles from "./MediaView.module.css";
import { Avatar } from "../Avatar";
import { RaisedHandIndicator } from "../reactions/RaisedHandIndicator";
interface Props extends ComponentProps<typeof animated.div> {
className?: string;
@@ -64,26 +65,6 @@ export const MediaView = forwardRef<HTMLDivElement, Props>(
) => {
const { t } = useTranslation();
const [raisedHandDuration, setRaisedHandDuration] = useState("");
useEffect(() => {
if (!raisedHandTime) {
return;
}
setRaisedHandDuration("00:00");
const to = setInterval(() => {
const totalSeconds = Math.ceil(
(new Date().getTime() - raisedHandTime.getTime()) / 1000,
);
const seconds = totalSeconds % 60;
const minutes = Math.floor(totalSeconds / 60);
setRaisedHandDuration(
`${minutes < 10 ? "0" : ""}${minutes}:${seconds < 10 ? "0" : ""}${seconds}`,
);
}, 1000);
return (): void => clearInterval(to);
}, [setRaisedHandDuration, raisedHandTime]);
return (
<animated.div
className={classNames(styles.media, className, {
@@ -115,16 +96,7 @@ export const MediaView = forwardRef<HTMLDivElement, Props>(
)}
</div>
<div className={styles.fg}>
{raisedHandTime && (
<div className={styles.raisedHandWidget}>
<div className={styles.raisedHand}>
<span role="img" aria-label="raised hand">
</span>
</div>
<p>{raisedHandDuration}</p>
</div>
)}
<RaisedHandIndicator raisedHandTime={raisedHandTime} />
<div className={styles.nameTag}>
{nameTagLeadingIcon}
<Text as="span" size="sm" weight="medium" className={styles.name}>