diff --git a/src/UrlParams.test.ts b/src/UrlParams.test.ts index dce46754..b65638e0 100644 --- a/src/UrlParams.test.ts +++ b/src/UrlParams.test.ts @@ -243,4 +243,16 @@ describe("UrlParams", () => { expect(getUrlParams("?intent=join_existing").skipLobby).toBe(false); }); }); + describe("header", () => { + it("uses header if provided", () => { + expect(getUrlParams("?header=app_bar&hideHeader=true").header).toBe( + "app_bar", + ); + expect(getUrlParams("?header=none&hideHeader=false").header).toBe("none"); + }); + it("converts hideHeader to the correct header value", () => { + expect(getUrlParams("?hideHeader=true").header).toBe("none"); + expect(getUrlParams("?hideHeader=false").header).toBe("standard"); + }); + }); }); diff --git a/src/UrlParams.ts b/src/UrlParams.ts index 35d19868..9f89fd47 100644 --- a/src/UrlParams.ts +++ b/src/UrlParams.ts @@ -267,12 +267,13 @@ export const getUrlParams = ( intent = UserIntent.Unknown; } - // Check hideHeader for backwards compatibility - let header = parser.getFlagParam("hideHeader") - ? HeaderStyle.None - : parser.getParam("header"); - if (header !== HeaderStyle.None && header !== HeaderStyle.AppBar) - header = HeaderStyle.Standard; + // Check hideHeader for backwards compatibility. If header is set, hideHeader + // is ignored. + const header = + parser.getParam("header") ?? + (parser.getFlagParam("hideHeader") + ? HeaderStyle.None + : HeaderStyle.Standard); const widgetId = parser.getParam("widgetId"); const parentUrl = parser.getParam("parentUrl");