From ab675cf00ba743396e7c92397ba4a3b8e60acf9d Mon Sep 17 00:00:00 2001
From: Timo K <toger5@hotmail.de>
Date: Mon, 1 Dec 2025 20:26:54 +0100
Subject: [PATCH] fix test caused by
 `remoteParticipantsWithTracks`->`remoteParticipants`

---
 src/state/CallViewModel/CallViewModel.ts             |  2 +-
 .../CallViewModel/remoteMembers/Connection.test.ts   | 12 ++++++++----
 src/state/CallViewModel/remoteMembers/Connection.ts  |  2 +-
 .../remoteMembers/ConnectionManager.test.ts          |  7 +++----
 4 files changed, 13 insertions(+), 10 deletions(-)

diff --git a/src/state/CallViewModel/CallViewModel.ts b/src/state/CallViewModel/CallViewModel.ts
index a9ce0335..ba83203c 100644
--- a/src/state/CallViewModel/CallViewModel.ts
+++ b/src/state/CallViewModel/CallViewModel.ts
@@ -101,7 +101,7 @@ import { createHomeserverConnected$ } from "./localMember/HomeserverConnected.ts
 import {
   createLocalMembership$,
   enterRTCSession,
-  LocalMemberConnectionState,
+  type LocalMemberConnectionState,
   RTCBackendState,
 } from "./localMember/LocalMembership.ts";
 import { createLocalTransport$ } from "./localMember/LocalTransport.ts";
diff --git a/src/state/CallViewModel/remoteMembers/Connection.test.ts b/src/state/CallViewModel/remoteMembers/Connection.test.ts
index 57becef8..323df5d7 100644
--- a/src/state/CallViewModel/remoteMembers/Connection.test.ts
+++ b/src/state/CallViewModel/remoteMembers/Connection.test.ts
@@ -412,8 +412,10 @@ describe("Publishing participants observations", () => {
       fakeRoomEventEmiter.emit(RoomEvent.ParticipantConnected, p),
     );
 
-    // At this point there should be no publishers
-    expect(observedPublishers.pop()!.length).toEqual(0);
+    // At this point there should be ~~no~~ publishers
+    // We do have publisher now, since we do not filter for publishers anymore (to also have participants with only data tracks)
+    // The filtering we do is just based on the matrixRTC member events.
+    expect(observedPublishers.pop()!.length).toEqual(4);
 
     participants = [
       fakeRemoteLivekitParticipant("@alice:example.org:DEV000", 1),
@@ -453,8 +455,10 @@ describe("Publishing participants observations", () => {
       fakeRoomEventEmiter.emit(RoomEvent.ParticipantConnected, participant);
     }
 
-    // At this point there should be no publishers
-    expect(observedPublishers.pop()!.length).toEqual(0);
+    // At this point there should be ~~no~~ publishers
+    // We do have publisher now, since we do not filter for publishers anymore (to also have participants with only data tracks)
+    // The filtering we do is just based on the matrixRTC member events.
+    expect(observedPublishers.pop()!.length).toEqual(1);
 
     participants = [fakeRemoteLivekitParticipant("@bob:example.org:DEV111", 1)];
 
diff --git a/src/state/CallViewModel/remoteMembers/Connection.ts b/src/state/CallViewModel/remoteMembers/Connection.ts
index 7aac55e2..323cfc8a 100644
--- a/src/state/CallViewModel/remoteMembers/Connection.ts
+++ b/src/state/CallViewModel/remoteMembers/Connection.ts
@@ -221,7 +221,7 @@ export class Connection {
     this.client = client;
 
     // REMOTE participants with track!!!
-    // this.remoteParticipantsWithTracks$
+    // this.remoteParticipants$
     this.remoteParticipants$ = scope.behavior(
       // only tracks remote participants
       connectedParticipantsObserver(this.livekitRoom, {
diff --git a/src/state/CallViewModel/remoteMembers/ConnectionManager.test.ts b/src/state/CallViewModel/remoteMembers/ConnectionManager.test.ts
index b5076285..8a4df4ed 100644
--- a/src/state/CallViewModel/remoteMembers/ConnectionManager.test.ts
+++ b/src/state/CallViewModel/remoteMembers/ConnectionManager.test.ts
@@ -52,7 +52,7 @@ beforeEach(() => {
       (transport: LivekitTransport, scope: ObservableScope) => {
         const mockConnection = {
           transport,
-          remoteParticipantsWithTracks$: new BehaviorSubject([]),
+          remoteParticipants$: new BehaviorSubject([]),
         } as unknown as Connection;
         vi.mocked(mockConnection).start = vi.fn();
         vi.mocked(mockConnection).stop = vi.fn();
@@ -200,7 +200,7 @@ describe("connections$ stream", () => {
 });
 
 describe("connectionManagerData$ stream", () => {
-  // Used in test to control fake connections' remoteParticipantsWithTracks$ streams
+  // Used in test to control fake connections' remoteParticipants$ streams
   let fakePublishingParticipantsStreams: Map<
     string,
     Behavior<LivekitParticipant[]>
@@ -232,8 +232,7 @@ describe("connectionManagerData$ stream", () => {
           >([]);
           const mockConnection = {
             transport,
-            remoteParticipantsWithTracks$:
-              getPublishingParticipantsFor(transport),
+            remoteParticipants$: getPublishingParticipantsFor(transport),
           } as unknown as Connection;
           vi.mocked(mockConnection).start = vi.fn();
           vi.mocked(mockConnection).stop = vi.fn();