review: smaller changes

- use correct button styles
 - move overrides to options
 - add flex-wrap: nowrap
This commit is contained in:
Timo K
2026-04-14 17:44:31 +02:00
parent f7e1fa74cd
commit ab751e8c38
8 changed files with 31 additions and 20 deletions

View File

@@ -79,6 +79,7 @@ Please see LICENSE in the repository root for full details.
display: flex;
gap: var(--cpd-space-4x);
flex-direction: row;
flex-wrap: nowrap;
}
.logo {

View File

@@ -113,8 +113,7 @@ function createInCallView(args: CreateInCallViewArgs = {}): RenderResult & {
const { vm, rtcSession } = getBasicCallViewModelEnvironment(
[local, alice],
undefined,
{},
args.mediaDevices,
{ mediaDeviceOverride: args.mediaDevices },
);
rtcSession.joined = true;

View File

@@ -38,8 +38,8 @@ import {
MicButton,
VideoButton,
ShareScreenButton,
SettingsButton,
ReactionToggleButton,
SettingsIconButton,
} from "../button";
import { Header, LeftNav, RightNav, RoomHeaderInfo } from "../Header";
import { HeaderStyle, useUrlParams } from "../UrlParams";
@@ -645,7 +645,7 @@ export const InCallView: FC<InCallViewProps> = ({
if (audioOutputButton) buttons.push(audioOutputButton);
useAppBarSecondaryButton(
<SettingsButton forAppBar key="settings" onClick={openSettings} />,
<SettingsIconButton key="settings" onClick={openSettings} />,
);
buttons.push(
@@ -686,7 +686,11 @@ export const InCallView: FC<InCallViewProps> = ({
// Settings button is also shown in the app bar if present
headerStyle !== HeaderStyle.AppBar &&
layout.type !== "pip" && (
<SettingsButton key="settings" onClick={openSettings} />
<SettingsIconButton
kind="secondary"
key="settings"
onClick={openSettings}
/>
)}
{headerStyle !== "none" && logo}

View File

@@ -36,7 +36,7 @@ import { InviteButton } from "../button/InviteButton";
import {
EndCallButton,
MicButton,
SettingsButton,
SettingsIconButton,
VideoButton,
} from "../button/Button";
import { SettingsModal, defaultSettingsTab } from "../settings/SettingsModal";
@@ -228,7 +228,7 @@ export const LobbyView: FC<Props> = ({
</div>
<div className={inCallStyles.footer}>
{recentsButtonInFooter && recentsButton}
<SettingsButton onClick={openSettings} />
<SettingsIconButton kind="secondary" onClick={openSettings} />
<div className={inCallStyles.buttons}>
<MicButton
enabled={audioEnabled}