From affe6f0c45e8f942be1d72e996943f479b08d277 Mon Sep 17 00:00:00 2001 From: Timo K Date: Fri, 1 Aug 2025 13:13:20 +0200 Subject: [PATCH] Dont construct logger before rageshake initialization Signed-off-by: Timo K --- src/controls.ts | 4 +-- src/livekit/MatrixAudioRenderer.tsx | 7 ++-- src/state/MediaDevices.ts | 52 +++++++++++++++++++++-------- 3 files changed, 43 insertions(+), 20 deletions(-) diff --git a/src/controls.ts b/src/controls.ts index 03a12e5a..6a050cb0 100644 --- a/src/controls.ts +++ b/src/controls.ts @@ -6,9 +6,7 @@ Please see LICENSE in the repository root for full details. */ import { Subject } from "rxjs"; -import { logger as rootLogger } from "matrix-js-sdk/lib/logger"; - -const logger = rootLogger.getChild("[controlled-output]"); +import { logger } from "matrix-js-sdk/lib/logger"; export interface Controls { canEnterPip(): boolean; diff --git a/src/livekit/MatrixAudioRenderer.tsx b/src/livekit/MatrixAudioRenderer.tsx index 1afa53e5..d649756f 100644 --- a/src/livekit/MatrixAudioRenderer.tsx +++ b/src/livekit/MatrixAudioRenderer.tsx @@ -14,13 +14,12 @@ import { type AudioTrackProps, } from "@livekit/components-react"; import { type CallMembership } from "matrix-js-sdk/lib/matrixrtc"; -import { logger as rootLogger } from "matrix-js-sdk/lib/logger"; +import { logger } from "matrix-js-sdk/lib/logger"; import { useEarpieceAudioConfig } from "../MediaDevicesContext"; import { useReactiveState } from "../useReactiveState"; import * as controls from "../controls"; -const logger = rootLogger.getChild("[MatrixAudioRenderer]"); export interface MatrixAudioRendererProps { /** * The list of participants to render audio for. @@ -72,7 +71,7 @@ export function MatrixAudioRenderer({ const logInvalid = (identity: string, validIdentities: Set): void => { if (loggedInvalidIdentities.current.has(identity)) return; logger.warn( - `Audio track ${identity} has no matching matrix call member`, + `[MatrixAudioRenderer] Audio track ${identity} has no matching matrix call member`, `current members: ${Array.from(validIdentities.values())}`, `track will not get rendered`, ); @@ -102,7 +101,7 @@ export function MatrixAudioRenderer({ useEffect(() => { if (!tracks.some((t) => !validIdentities.has(t.participant.identity))) { logger.debug( - `All audio tracks have a matching matrix call member identity.`, + `[MatrixAudioRenderer] All audio tracks have a matching matrix call member identity.`, ); loggedInvalidIdentities.current.clear(); } diff --git a/src/state/MediaDevices.ts b/src/state/MediaDevices.ts index 3a09bf91..f0f49343 100644 --- a/src/state/MediaDevices.ts +++ b/src/state/MediaDevices.ts @@ -17,7 +17,7 @@ import { type Observable, } from "rxjs"; import { createMediaDeviceObserver } from "@livekit/components-core"; -import { logger as rootLogger } from "matrix-js-sdk/lib/logger"; +import { type Logger, logger as rootLogger } from "matrix-js-sdk/lib/logger"; import { audioInput as audioInputSetting, @@ -38,7 +38,6 @@ import { type Behavior, constant } from "./Behavior"; // This hardcoded id is used in EX ios! It can only be changed in coordination with // the ios swift team. const EARPIECE_CONFIG_ID = "earpiece-id"; -const logger = rootLogger.getChild("[MediaDevices]"); export type DeviceLabel = | { type: "name"; name: string } @@ -100,6 +99,7 @@ function availableRawDevices$( kind: MediaDeviceKind, usingNames$: Behavior, scope: ObservableScope, + logger: Logger, ): Behavior { const logError = (e: Error): void => logger.error("Error creating MediaDeviceObserver", e); @@ -162,8 +162,15 @@ function selectDevice$