From b7fc86ee068d92a36aff85bba46cb6b544561792 Mon Sep 17 00:00:00 2001 From: Valere Date: Mon, 1 Dec 2025 15:25:17 +0100 Subject: [PATCH] review: move setGridMode close to the value it sets --- src/state/CallViewModel/CallViewModel.ts | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/state/CallViewModel/CallViewModel.ts b/src/state/CallViewModel/CallViewModel.ts index 55e004df..ded49d39 100644 --- a/src/state/CallViewModel/CallViewModel.ts +++ b/src/state/CallViewModel/CallViewModel.ts @@ -992,6 +992,13 @@ export function createCallViewModel$( ); const gridModeUserSelection$ = new BehaviorSubject("grid"); + + // Callback to set the grid mode desired by the user. + // Notice that this is only a preference, the actual grid mode can be overridden + // if there is a remote screen share active. + const setGridMode = (value: GridMode): void => { + gridModeUserSelection$.next(value); + }; /** * The layout mode of the media tile grid. */ @@ -1028,10 +1035,6 @@ export function createCallViewModel$( "grid", ); - const setGridMode = (value: GridMode): void => { - gridModeUserSelection$.next(value); - }; - const gridLayoutMedia$: Observable = combineLatest( [grid$, spotlight$], (grid, spotlight) => ({