From b9700b998602938c75c6e7b53458725da52c49a0 Mon Sep 17 00:00:00 2001 From: Valere Date: Fri, 14 Mar 2025 14:50:47 +0100 Subject: [PATCH] code review --- .github/workflows/playwright.yml | 5 +++-- README.md | 2 +- playwright.config.ts | 15 +++++++-------- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/workflows/playwright.yml b/.github/workflows/playwright.yml index 97798480..ddd23bbb 100644 --- a/.github/workflows/playwright.yml +++ b/.github/workflows/playwright.yml @@ -11,9 +11,10 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: lts/* + cache: "yarn" + node-version-file: ".node-version" - name: Install dependencies - run: npm install -g yarn && yarn + run: yarn install --frozen-lockfile - name: Install Playwright Browsers run: yarn playwright install --with-deps - name: Run backend components diff --git a/README.md b/README.md index 75e6b0df..70f46106 100644 --- a/README.md +++ b/README.md @@ -226,7 +226,7 @@ npx playwright codegen ``` This will record your action and write the test code for you. Use the tool bar to test visibility, text content, -clicking.. +clicking. ##### Investigate a failed test from the CI diff --git a/playwright.config.ts b/playwright.config.ts index 1d3db581..0724a43a 100644 --- a/playwright.config.ts +++ b/playwright.config.ts @@ -1,12 +1,11 @@ -import { defineConfig, devices } from "@playwright/test"; +/* +Copyright 2025 New Vector Ltd. -/** - * Read environment variables from file. - * https://github.com/motdotla/dotenv - */ -// import dotenv from 'dotenv'; -// import path from 'path'; -// dotenv.config({ path: path.resolve(__dirname, '.env') }); +SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial +Please see LICENSE in the repository root for full details. +*/ + +import { defineConfig, devices } from "@playwright/test"; /** * See https://playwright.dev/docs/test-configuration.