From c1f821ca0f1fe002deea4f7efc23e0e09da739fb Mon Sep 17 00:00:00 2001 From: fkwp Date: Thu, 23 Apr 2026 15:33:00 +0200 Subject: [PATCH] Update default sync disconnect grace period to 10000ms in configuration and related functions --- src/config/ConfigOptions.ts | 4 ++-- src/state/CallViewModel/CallViewModel.ts | 2 -- src/state/CallViewModel/localMember/HomeserverConnected.ts | 6 +++--- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/src/config/ConfigOptions.ts b/src/config/ConfigOptions.ts index d5839fb3..1781dc97 100644 --- a/src/config/ConfigOptions.ts +++ b/src/config/ConfigOptions.ts @@ -100,7 +100,7 @@ export interface ConfigOptions { /** * Grace period in milliseconds to wait before reporting the sync loop as disconnected. * This allows brief sync interruptions without triggering a reconnection message. - * Default is 60000ms (60 seconds). Set to 0 to disable the grace period. + * Default is 10000ms (10 seconds). Set to 0 to disable the grace period. */ sync_disconnect_grace_period_ms?: number; @@ -175,6 +175,6 @@ export const DEFAULT_CONFIG: ResolvedConfigOptions = { features: { feature_use_device_session_member_events: true, }, - sync_disconnect_grace_period_ms: 60000, + sync_disconnect_grace_period_ms: 10000, ssla: "https://static.element.io/legal/element-software-and-services-license-agreement-uk-1.pdf", }; diff --git a/src/state/CallViewModel/CallViewModel.ts b/src/state/CallViewModel/CallViewModel.ts index 8677f2d0..e298bcfd 100644 --- a/src/state/CallViewModel/CallViewModel.ts +++ b/src/state/CallViewModel/CallViewModel.ts @@ -83,7 +83,6 @@ import { E2eeType } from "../../e2ee/e2eeType"; import { MatrixKeyProvider } from "../../e2ee/matrixKeyProvider"; import { type MuteStates } from "../MuteStates"; import { getUrlParams, HeaderStyle } from "../../UrlParams"; -import { Config } from "../../config/Config"; import { type ProcessorState } from "../../livekit/TrackProcessorContext"; import { ElementWidgetActions, widget } from "../../widget"; import { @@ -537,7 +536,6 @@ export function createCallViewModel$( scope, client, matrixRTCSession, - Config.get().sync_disconnect_grace_period_ms, ), muteStates, joinMatrixRTC: (transport: LivekitTransportConfig) => { diff --git a/src/state/CallViewModel/localMember/HomeserverConnected.ts b/src/state/CallViewModel/localMember/HomeserverConnected.ts index cad987c8..d66d8657 100644 --- a/src/state/CallViewModel/localMember/HomeserverConnected.ts +++ b/src/state/CallViewModel/localMember/HomeserverConnected.ts @@ -54,7 +54,7 @@ export interface HomeserverConnected { * @param client - The Matrix client to monitor sync state. * @param matrixRTCSession - The RTC session to monitor membership. * @param gracePeriodMs - Grace period in milliseconds to wait before reporting sync disconnect. - * If not provided, uses the config value (default 60000ms). + * If not provided, uses the config value (default 10000ms). */ export function createHomeserverConnected$( scope: ObservableScope, @@ -63,9 +63,9 @@ export function createHomeserverConnected$( Pick, gracePeriodMs?: number, ): HomeserverConnected { - // Get grace period from parameter or config (default 60000ms) + // Get grace period from parameter or config (default 10000ms) const graceMs = - gracePeriodMs ?? Config.get().sync_disconnect_grace_period_ms ?? 60000; + gracePeriodMs ?? Config.get().sync_disconnect_grace_period_ms ?? 10000; const syncing$ = ( fromEvent(client, ClientEvent.Sync) as Observable<[SyncState]>