review

locales/en/app.json

@@ -71,7 +71,7 @@
     "matrix_id": "Matrix ID: {{id}}",
     "show_connection_stats": "Show connection statistics",
     "show_non_member_tiles": "Show tiles for non-member media",
-    "use_NewMembershipmanager": "Use the new implementation of the call MembershipManager"
+    "use_new_membership_manager": "Use the new implementation of the call MembershipManager"
   },
   "disconnected_banner": "Connectivity to the server has been lost.",
   "error": {

src/room/GroupCallView.tsx

@@ -160,7 +160,7 @@ export const GroupCallView: FC<Props> = ({
   const roomName = useRoomName(room);
   const roomAvatar = useRoomAvatar(room);
   const { perParticipantE2EE, returnToLobby } = useUrlParams();
-  const e2eeSystem = useRoomEncryptionSystem(rtcSession.room.roomId);
+  const e2eeSystem = useRoomEncryptionSystem(room.roomId);
   const [newMembershipManager] = useSetting(useNewMembershipManagerSetting);
 
   usePageTitle(roomName);
@@ -170,22 +170,13 @@ export const GroupCallView: FC<Props> = ({
       userId: client.getUserId()!,
       displayName: displayName!,
       avatarUrl: avatarUrl!,
-      roomId: rtcSession.room.roomId,
+      roomId: room.roomId,
       roomName,
       roomAlias: room.getCanonicalAlias(),
       roomAvatar,
       e2eeSystem,
     };
-  }, [
+  }, [client, displayName, avatarUrl, roomName, room, roomAvatar, e2eeSystem]);
-    client,
-    displayName,
-    avatarUrl,
-    rtcSession.room.roomId,
-    roomName,
-    room,
-    roomAvatar,
-    e2eeSystem,
-  ]);
 
   // Count each member only once, regardless of how many devices they use
   const participantCount = useMemo(
@@ -319,8 +310,7 @@ export const GroupCallView: FC<Props> = ({
   ]);
 
   const [left, setLeft] = useState(false);
-  const [error, setError] =
+  const [error, setError] = useState<ElementCallError | null>(null);
-    useState<ElementCallError | null>(null);
   const navigate = useNavigate();
 
   const onLeave = useCallback(
@@ -334,7 +324,7 @@ export const GroupCallView: FC<Props> = ({
       // Otherwise the iFrame gets killed before the callEnded event got tracked.
       const posthogRequest = new Promise((resolve) => {
         PosthogAnalytics.instance.eventCallEnded.track(
-          rtcSession.room.roomId,
+          room.roomId,
           rtcSession.memberships.length,
           sendInstantly,
           rtcSession,
@@ -363,11 +353,12 @@ export const GroupCallView: FC<Props> = ({
         });
     },
     [
+      leaveSoundContext,
       widget,
       rtcSession,
+      room.roomId,
       isPasswordlessUser,
       confineToRoom,
-      leaveSoundContext,
       navigate,
     ],
   );

src/settings/DeveloperSettingsTab.tsx

@@ -143,7 +143,7 @@ export const DeveloperSettingsTab: FC<Props> = ({ client, livekitRoom }) => {
         <InputField
           id="useNewMembershipManager"
           type="checkbox"
-          label={t("developer_mode.use_NewMembershipmanager")}
+          label={t("developer_mode.use_new_membership_manager")}
           checked={!!useNewMembershipManager}
           onChange={useCallback(
             (event: ChangeEvent<HTMLInputElement>): void => {

src/utils/errors.ts

@@ -77,11 +77,6 @@ export class ConnectionLostError extends ElementCallError {
 
 export class RTCSessionError extends ElementCallError {
   public constructor(code: ErrorCode, message: string) {
-    super(
+    super("RTCSession Error", code, ErrorCategory.RTC_SESSION_FAILURE, message);
-      "RTCSession Error",
-      code,
-      ErrorCategory.RTC_SESSION_FAILIOUR,
-      message,
-    );
   }
 }

src/utils/matrix.ts

@@ -69,7 +69,7 @@ async function waitForSync(client: MatrixClient): Promise<void> {
  * otherwise rust crypto will throw since it is not ready to initialize a new session.
  * If another client is running make sure `.logout()` is called before executing this function.
  * @param clientOptions Object of options passed through to the client
- * @param restore If the rust crypto should be reset before the cient initialization or
+ * @param restore If the rust crypto should be reset before the client initialization or
  * if the initialization should try to restore the crypto state from the indexDB.
  * @returns The MatrixClient instance
  */