From c70536996ef8515d3a96cf958101be13413e9d4d Mon Sep 17 00:00:00 2001 From: Michael Kaye <1917473+michaelkaye@users.noreply.github.com> Date: Wed, 3 May 2023 16:27:35 +0100 Subject: [PATCH] Work around data-testid issue by tagging the icon not the Item. --- src/UserMenu.tsx | 9 +++++++-- src/profile/ProfileModal.tsx | 7 ++++++- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/src/UserMenu.tsx b/src/UserMenu.tsx index 6a1b3a07..55fc05de 100644 --- a/src/UserMenu.tsx +++ b/src/UserMenu.tsx @@ -116,8 +116,13 @@ export function UserMenu({ {(props) => ( {items.map(({ key, icon: Icon, label, dataTestid }) => ( - - + + {label} ))} diff --git a/src/profile/ProfileModal.tsx b/src/profile/ProfileModal.tsx index adb1e2bd..49f78caf 100644 --- a/src/profile/ProfileModal.tsx +++ b/src/profile/ProfileModal.tsx @@ -119,6 +119,7 @@ export function ProfileModal({ client, ...rest }: Props) { placeholder={t("Display name")} value={displayName} onChange={onChangeDisplayName} + data-testid="profile_displayname" /> {error && ( @@ -130,7 +131,11 @@ export function ProfileModal({ client, ...rest }: Props) { -