From 735d63d393bd534aac375ef34df6eb9e2c73e026 Mon Sep 17 00:00:00 2001 From: Robin Date: Thu, 10 Jul 2025 16:07:14 -0400 Subject: [PATCH 1/2] Prefer showing the reaction button at small screen widths Rather than the 'share screen' button. Small screens are most likely to be mobile devices which wouldn't have the ability to share their screen, anyways. --- src/room/InCallView.module.css | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/room/InCallView.module.css b/src/room/InCallView.module.css index 41d48db1..96b8a368 100644 --- a/src/room/InCallView.module.css +++ b/src/room/InCallView.module.css @@ -108,13 +108,6 @@ Please see LICENSE in the repository root for full details. } @media (max-width: 370px) { - .raiseHand { - display: none; - } -} - -@media (max-width: 340px) { - .invite, .shareScreen { display: none; } @@ -126,6 +119,13 @@ Please see LICENSE in the repository root for full details. } } +@media (max-width: 320px) { + .invite, + .raiseHand { + display: none; + } +} + @media (max-height: 400px) { .footer { padding-block: var(--cpd-space-4x); From 30024877fcd868d9dcc308c15115baf43d96d9b4 Mon Sep 17 00:00:00 2001 From: Robin Date: Thu, 14 Aug 2025 17:00:56 +0200 Subject: [PATCH 2/2] Test that the reaction button is visible at small screen widths --- playwright/create-call.spec.ts | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/playwright/create-call.spec.ts b/playwright/create-call.spec.ts index 759cd2db..6f03272e 100644 --- a/playwright/create-call.spec.ts +++ b/playwright/create-call.spec.ts @@ -40,6 +40,11 @@ test("Start a new call then leave and show the feedback screen", async ({ // The tooltip with the name should be visible await expect(page.getByTestId("name_tag")).toContainText("John Doe"); + // Resize the window to resemble a small mobile phone + await page.setViewportSize({ width: 350, height: 660 }); + // We should still be able to send reactions at this screen size + await expect(page.getByRole("button", { name: "Reactions" })).toBeVisible(); + // leave the call await page.getByTestId("incall_leave").click(); await expect(page.getByRole("heading")).toContainText(