diff --git a/playwright/mobile/create-call-mobile.spec.ts b/playwright/mobile/create-call-mobile.spec.ts index 322be5eb..45424611 100644 --- a/playwright/mobile/create-call-mobile.spec.ts +++ b/playwright/mobile/create-call-mobile.spec.ts @@ -98,7 +98,9 @@ mobileTest( // Open settings to select earpiece await guestPage.getByRole("button", { name: "Settings" }).click(); - await guestPage.getByText("Handset", { exact: true }).click(); + await guestPage + .getByRole("radio", { name: "Handset", exact: true }) + .click(); // dismiss settings await guestPage.locator("#root").getByLabel("Settings").press("Escape"); diff --git a/src/AppBar.tsx b/src/AppBar.tsx index aaa7565e..86d150ee 100644 --- a/src/AppBar.tsx +++ b/src/AppBar.tsx @@ -68,8 +68,8 @@ export const AppBar: FC = ({ children }) => { > - - + + diff --git a/src/__snapshots__/AppBar.test.tsx.snap b/src/__snapshots__/AppBar.test.tsx.snap index 7247c6b9..0df18767 100644 --- a/src/__snapshots__/AppBar.test.tsx.snap +++ b/src/__snapshots__/AppBar.test.tsx.snap @@ -17,7 +17,7 @@ exports[`AppBar > renders 1`] = ` class="_icon-button_1215g_8" data-kind="primary" role="button" - style="--cpd-icon-button-size: 32px;" + style="--cpd-icon-button-size: 24px;" tabindex="0" >
renders 1`] = ` style="--cpd-icon-button-size: 100%;" >
+ + + {/* Don't mind this odd placement, it's just a little debug label */} + {debugTileLayout ? `Tiles generation: ${tileStoreGeneration}` : undefined} +
+ ); + const footer = (
= ({ !showFooter || (!showControls && headerStyle === "none"), })} > - {headerStyle !== "none" && ( -
- - - {/* Don't mind this odd placement, it's just a little debug label */} - {debugTileLayout - ? `Tiles generation: ${tileStoreGeneration}` - : undefined} -
- )} +
+ {showControls && + // Settings button is also shown in the app bar if present + headerStyle !== HeaderStyle.AppBar && + layout.type !== "pip" && ( + + )} + + {headerStyle !== "none" && logo} +
+ {showControls &&
{buttons}
} {showControls && ( = ({
{recentsButtonInFooter && recentsButton} +
= ({ onClick={toggleVideo ?? undefined} disabled={toggleVideo === null} /> - {!confineToRoom && }
diff --git a/src/room/__snapshots__/InCallView.test.tsx.snap b/src/room/__snapshots__/InCallView.test.tsx.snap index 3a917230..955c061e 100644 --- a/src/room/__snapshots__/InCallView.test.tsx.snap +++ b/src/room/__snapshots__/InCallView.test.tsx.snap @@ -166,108 +166,138 @@ exports[`InCallView > rendering > renders 1`] = ` class="footer" > + +
rendering > renders 1`] = ` -