From cf642aa670b5586c97e7d1e568259071f16bd084 Mon Sep 17 00:00:00 2001 From: Timo K Date: Wed, 8 Apr 2026 16:05:46 +0200 Subject: [PATCH 01/14] Move settings button out of the button bar. User overflow button instead: at the top for mobile, bottom left for web. --- src/AppBar.tsx | 11 ++-- src/button/Button.tsx | 10 ++-- src/room/InCallView.module.css | 30 ++++++++--- src/room/InCallView.tsx | 98 ++++++++++++++++++---------------- src/room/LobbyView.tsx | 2 +- 5 files changed, 89 insertions(+), 62 deletions(-) diff --git a/src/AppBar.tsx b/src/AppBar.tsx index aaa7565e..72ee9285 100644 --- a/src/AppBar.tsx +++ b/src/AppBar.tsx @@ -16,7 +16,7 @@ import { useMemo, useState, } from "react"; -import { Heading, IconButton, Tooltip } from "@vector-im/compound-web"; +import { Button, Heading, Tooltip } from "@vector-im/compound-web"; import { CollapseIcon } from "@vector-im/compound-design-tokens/assets/web/icons"; import { useTranslation } from "react-i18next"; @@ -68,9 +68,12 @@ export const AppBar: FC = ({ children }) => { > - - - +
rendering > renders 1`] = ` class="footer" >
rendering > renders 1`] = ` -
{recentsButtonInFooter && recentsButton} - +
; /** The version & compatibility mode of MatrixRTC that we should use. */ matrixRTCMode$?: Behavior; + mediaDeviceOverride?: MediaDevices; } // Do not play any sounds if the participant count has exceeded this diff --git a/src/utils/test-viewmodel.ts b/src/utils/test-viewmodel.ts index 8ab3c887..6d77a802 100644 --- a/src/utils/test-viewmodel.ts +++ b/src/utils/test-viewmodel.ts @@ -34,7 +34,6 @@ import { MockRTCSession, testScope, } from "./test"; -import { type MediaDevices } from "../state/MediaDevices"; import { aliceRtcMember, localRtcMember } from "./test-fixtures"; import { type RaisedHandInfo, type ReactionInfo } from "../reactions"; import { constant } from "../state/Behavior"; @@ -133,7 +132,6 @@ export function getBasicCallViewModelEnvironment( members: RoomMember[], initialRtcMemberships: CallMembership[] = [localRtcMember, aliceRtcMember], callViewModelOptions: Partial = {}, - mediaDevicesOverride?: MediaDevices, ): { vm: CallViewModel; rtcMemberships$: BehaviorSubject; @@ -154,7 +152,7 @@ export function getBasicCallViewModelEnvironment( testScope(), rtcSession.asMockedSession(), matrixRoom, - mediaDevicesOverride ?? mockMediaDevices({}), + callViewModelOptions.mediaDeviceOverride ?? mockMediaDevices({}), mockMuteStates(), { encryptionSystem: { kind: E2eeType.PER_PARTICIPANT }, From 32823aef926bff3c76375ac76c681759ae43fe8f Mon Sep 17 00:00:00 2001 From: Timo K Date: Tue, 14 Apr 2026 18:15:20 +0200 Subject: [PATCH 10/14] test and lints --- src/__snapshots__/AppBar.test.tsx.snap | 32 +++++++++++-------- src/button/Button.tsx | 26 +++++++-------- .../__snapshots__/InCallView.test.tsx.snap | 32 +++++++++++-------- 3 files changed, 49 insertions(+), 41 deletions(-) diff --git a/src/__snapshots__/AppBar.test.tsx.snap b/src/__snapshots__/AppBar.test.tsx.snap index 2dd608a6..7247c6b9 100644 --- a/src/__snapshots__/AppBar.test.tsx.snap +++ b/src/__snapshots__/AppBar.test.tsx.snap @@ -14,24 +14,28 @@ exports[`AppBar > renders 1`] = ` >
= (props) => { ); }; -interface SettingsButtonProps extends ComponentPropsWithoutRef<"button"> { - size?: "sm" | "lg"; -} -export const SettingsButton: FC = (props) => { - const { t } = useTranslation(); - const Icon = - platform === "android" ? OverflowVerticalIcon : OverflowHorizontalIcon; - return ( - - - - ); -}; +// interface SettingsButtonProps extends ComponentPropsWithoutRef<"button"> { +// size?: "sm" | "lg"; +// } +// const SettingsButton: FC = (props) => { +// const { t } = useTranslation(); +// const Icon = +// platform === "android" ? OverflowVerticalIcon : OverflowHorizontalIcon; +// return ( +// +// +// +// ); +// }; diff --git a/src/room/__snapshots__/InCallView.test.tsx.snap b/src/room/__snapshots__/InCallView.test.tsx.snap index 7ef7298b..dafc8564 100644 --- a/src/room/__snapshots__/InCallView.test.tsx.snap +++ b/src/room/__snapshots__/InCallView.test.tsx.snap @@ -170,24 +170,28 @@ exports[`InCallView > rendering > renders 1`] = ` >