From db005bbe3e3c8b6a3d9d3e625eb3ddf82205136f Mon Sep 17 00:00:00 2001 From: Timo Date: Mon, 11 Nov 2024 18:21:07 +0100 Subject: [PATCH] review andrew --- README.md | 2 +- public/locales/en-GB/app.json | 2 +- src/room/RoomPage.tsx | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index c4c252ad..43a2dce0 100644 --- a/README.md +++ b/README.md @@ -106,7 +106,7 @@ rc_message: MSC3266 allows to request a room summary of rooms you are not joined. The summary contains the room join rules. We need that to decide if the user gets -prompted with the option to knock ("Request to join"), a cannot join error or the +prompted with the option to knock ("Request to join call"), a cannot join error or the join view. Element Call requires a Livekit SFU alongside a [Livekit JWT diff --git a/public/locales/en-GB/app.json b/public/locales/en-GB/app.json index d64ea9dd..dc1b6010 100644 --- a/public/locales/en-GB/app.json +++ b/public/locales/en-GB/app.json @@ -81,7 +81,7 @@ "call_ended_heading": "Call ended", "failed_heading": "Failed to join", "failed_text": "Call not found or is not accessible.", - "knock_reject_body": "Your request was declined.", + "knock_reject_body": "Your request to join was declined.", "knock_reject_heading": "Access denied", "reason": "Reason" }, diff --git a/src/room/RoomPage.tsx b/src/room/RoomPage.tsx index 002dbb6d..49d594bb 100644 --- a/src/room/RoomPage.tsx +++ b/src/room/RoomPage.tsx @@ -112,7 +112,7 @@ export const RoomPage: FC = () => { case "canKnock": { wasInWaitForInviteState.current = wasInWaitForInviteState.current || - "waitForInvite" === groupCallState.kind; + groupCallState.kind === "waitForInvite"; const knock = groupCallState.kind === "canKnock" ? groupCallState.knock : null; const label: string | JSX.Element =