From e0c092399373057e28461c3345d22b4af25cc934 Mon Sep 17 00:00:00 2001 From: Timo K Date: Tue, 21 Oct 2025 14:16:24 +0200 Subject: [PATCH] review Signed-off-by: Timo K --- locales/en/app.json | 7 +++---- src/home/useGroupCallRooms.ts | 2 +- src/rtcSessionHelpers.ts | 2 +- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/locales/en/app.json b/locales/en/app.json index 6aa85c01..71b087ac 100644 --- a/locales/en/app.json +++ b/locales/en/app.json @@ -74,13 +74,12 @@ "matrix_id": "Matrix ID: {{id}}", "multi_sfu": "Multi-SFU media transport", "mute_all_audio": "Mute all audio (participants, reactions, join sounds)", - "show_connection_stats": "Show connection statistics", "prefer_sticky_events": { - "label": "Prefer sticky events", - "description": "Improves reliability of calls (requires homeserver support)" + "description": "Improves reliability of calls (requires homeserver support)", + "label": "Prefer sticky events" }, + "show_connection_stats": "Show connection statistics", "url_params": "URL parameters", - "use_new_membership_manager": "Use the new implementation of the call MembershipManager", "use_to_device_key_transport": "Use to device key transport. This will fallback to room key transport when another call member sent a room key" }, "disconnected_banner": "Connectivity to the server has been lost.", diff --git a/src/home/useGroupCallRooms.ts b/src/home/useGroupCallRooms.ts index bd54fabb..977b59ab 100644 --- a/src/home/useGroupCallRooms.ts +++ b/src/home/useGroupCallRooms.ts @@ -143,7 +143,7 @@ const roomHasCallMembershipEvents = (room: Room): boolean => { // Check for *active* calls using sticky events. for (const sticky of room._unstable_getStickyEvents()) { - if (sticky.getType() === EventType.GroupCallMemberPrefix) { + if (sticky.getType() === EventType.RTCMembership) { return true; } } diff --git a/src/rtcSessionHelpers.ts b/src/rtcSessionHelpers.ts index c6522394..8753105e 100644 --- a/src/rtcSessionHelpers.ts +++ b/src/rtcSessionHelpers.ts @@ -124,7 +124,7 @@ export async function enterRTCSession( }, ): Promise { const { encryptMedia, useExperimentalToDeviceTransport = false } = options; - const useMultiSfu = preferStickyEvents.getValue() ?? options.useMultiSfu; + const useMultiSfu = preferStickyEvents.getValue() || options.useMultiSfu; PosthogAnalytics.instance.eventCallEnded.cacheStartCall(new Date()); PosthogAnalytics.instance.eventCallStarted.track(rtcSession.room.roomId);