Matrix/element-call-Github
1
0
Fork 0
mirror of https://github.com/vector-im/element-call.git synced 2026-09-22 22:29:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add a background without putting it on

Browse Source 
- Whether choosing a file should also wear it is still open, so this does
  the smaller thing: the image joins the others and the user says when
- Reverts the auto-selection added earlier, which was never proven: the
  stories carry selection as a fixed arg, so nothing there could show it

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
fkwp
2026-09-17 23:01:54 +02:00
co-authored by Claude Opus 5
parent 31e67577b0
commit ea25cde725
1 changed files with 16 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/components/CallFooter.tsx
+16 -19
View File
@@ -214,27 +214,24 @@ export const CallFooter: FC<FooterProps> = ({
const onAddBackgroundImage = useCallback( const onAddBackgroundImage = useCallback(
(file: File): void => { (file: File): void => {
// Chosen for the user straight away: they picked this picture to use it, // Added, not chosen. Whether picking a file should also put it on is
// and leaving it unselected would ask them to pick it twice. // still open, so this does the smaller thing: the image appears among
// the others and the user says when to wear it.
setBackgroundEffectError(undefined); setBackgroundEffectError(undefined);
addBackground(file) addBackground(file).catch((e) => {
.then((id) => // TODO: FR-021 wants the user told what went wrong. There is no
selectBackgroundEffect?.(serializeEffect({ kind: "added", id })), // surface for that in the menu yet, and inventing one is design's
) // call, so for now this is only logged.
.catch((e) => { setBackgroundEffectError(whyRefused(e));
// TODO: FR-021 wants the user told what went wrong. There is no logger.warn(
// surface for that in the menu yet, and inventing one is design's e instanceof UnusableImage
// call, so for now this is only logged. ? `Cannot use that file as a background: ${e.reason}`
setBackgroundEffectError(whyRefused(e)); : "Could not keep that background",
logger.warn( e,
e instanceof UnusableImage );
? `Cannot use that file as a background: ${e.reason}` });
: "Could not keep that background",
e,
);
});
}, },
[addBackground, selectBackgroundEffect, whyRefused], [addBackground, whyRefused],
); );
// The catalogue is named here rather than in the view model: the names are // The catalogue is named here rather than in the view model: the names are