From ece04fdd68376f9f3c264cec4734794a94ef1205 Mon Sep 17 00:00:00 2001 From: Will Hunt Date: Mon, 4 Nov 2024 12:48:35 +0000 Subject: [PATCH] Fix some tests. --- src/reactions/RaisedHandIndicator.module.css | 52 ------------------- src/reactions/RaisedHandIndicator.test.tsx | 4 +- src/reactions/RaisedHandIndicator.tsx | 6 +-- src/reactions/ReactionIndicator.module.css | 14 ++--- src/reactions/ReactionIndicator.tsx | 14 ++--- .../RaisedHandIndicator.test.tsx.snap | 20 +++---- src/tile/MediaView.tsx | 4 +- 7 files changed, 31 insertions(+), 83 deletions(-) delete mode 100644 src/reactions/RaisedHandIndicator.module.css diff --git a/src/reactions/RaisedHandIndicator.module.css b/src/reactions/RaisedHandIndicator.module.css deleted file mode 100644 index 4c274374..00000000 --- a/src/reactions/RaisedHandIndicator.module.css +++ /dev/null @@ -1,52 +0,0 @@ -.raisedHandWidget { - display: flex; - background-color: var(--cpd-color-bg-subtle-primary); - border-radius: var(--cpd-radius-pill-effect); - color: var(--cpd-color-icon-secondary); -} - -.raisedHandWidget > p { - padding: none; - margin-top: auto; - margin-bottom: auto; - width: 4em; -} - -.raisedHandWidgetLarge > p { - padding: var(--cpd-space-2x); -} - -.raisedHandLarge { - margin: var(--cpd-space-2x); - padding: var(--cpd-space-2x); - padding-block: var(--cpd-space-2x); -} - -.raisedHand { - margin: var(--cpd-space-1x); - color: var(--cpd-color-icon-secondary); - background-color: var(--cpd-color-icon-secondary); - display: flex; - align-items: center; - border-radius: var(--cpd-radius-pill-effect); - user-select: none; - overflow: hidden; - box-shadow: var(--small-drop-shadow); - box-sizing: border-box; - max-inline-size: 100%; - max-width: fit-content; -} - -.raisedHand > span { - width: var(--cpd-space-6x); - height: var(--cpd-space-6x); - display: inline-block; - text-align: center; - font-size: 16px; -} - -.raisedHandLarge > span { - width: var(--cpd-space-8x); - height: var(--cpd-space-8x); - font-size: 22px; -} diff --git a/src/reactions/RaisedHandIndicator.test.tsx b/src/reactions/RaisedHandIndicator.test.tsx index 22a665a7..91e6a70d 100644 --- a/src/reactions/RaisedHandIndicator.test.tsx +++ b/src/reactions/RaisedHandIndicator.test.tsx @@ -33,10 +33,10 @@ describe("RaisedHandIndicator", () => { ); expect(container.firstChild).toMatchSnapshot(); }); - test("renders a smaller indicator when minature is specified", () => { + test("renders a smaller indicator when miniature is specified", () => { const dateTime = new Date(); const { container } = render( - , + , ); expect(container.firstChild).toMatchSnapshot(); }); diff --git a/src/reactions/RaisedHandIndicator.tsx b/src/reactions/RaisedHandIndicator.tsx index 0cc1e2c7..d1491895 100644 --- a/src/reactions/RaisedHandIndicator.tsx +++ b/src/reactions/RaisedHandIndicator.tsx @@ -20,11 +20,11 @@ const durationFormatter = new DurationFormat(undefined, { export function RaisedHandIndicator({ raisedHandTime, - minature, + miniature, showTimer, }: { raisedHandTime?: Date; - minature?: boolean; + miniature?: boolean; showTimer?: boolean; }): ReactNode { const [raisedHandDuration, setRaisedHandDuration] = useState(""); @@ -53,7 +53,7 @@ export function RaisedHandIndicator({ if (raisedHandTime) { return ( - + {showTimer &&

{raisedHandDuration}

}
); diff --git a/src/reactions/ReactionIndicator.module.css b/src/reactions/ReactionIndicator.module.css index 4c274374..8498ed80 100644 --- a/src/reactions/ReactionIndicator.module.css +++ b/src/reactions/ReactionIndicator.module.css @@ -1,28 +1,28 @@ -.raisedHandWidget { +.reactionIndicatorWidget { display: flex; background-color: var(--cpd-color-bg-subtle-primary); border-radius: var(--cpd-radius-pill-effect); color: var(--cpd-color-icon-secondary); } -.raisedHandWidget > p { +.reactionIndicatorWidget > p { padding: none; margin-top: auto; margin-bottom: auto; width: 4em; } -.raisedHandWidgetLarge > p { +.reactionIndicatorWidgetLarge > p { padding: var(--cpd-space-2x); } -.raisedHandLarge { +.reactionLarge { margin: var(--cpd-space-2x); padding: var(--cpd-space-2x); padding-block: var(--cpd-space-2x); } -.raisedHand { +.reaction { margin: var(--cpd-space-1x); color: var(--cpd-color-icon-secondary); background-color: var(--cpd-color-icon-secondary); @@ -37,7 +37,7 @@ max-width: fit-content; } -.raisedHand > span { +.reaction > span { width: var(--cpd-space-6x); height: var(--cpd-space-6x); display: inline-block; @@ -45,7 +45,7 @@ font-size: 16px; } -.raisedHandLarge > span { +.reactionLarge > span { width: var(--cpd-space-8x); height: var(--cpd-space-8x); font-size: 22px; diff --git a/src/reactions/ReactionIndicator.tsx b/src/reactions/ReactionIndicator.tsx index 677d3b30..2b22d854 100644 --- a/src/reactions/ReactionIndicator.tsx +++ b/src/reactions/ReactionIndicator.tsx @@ -13,24 +13,24 @@ import styles from "./ReactionIndicator.module.css"; export function ReactionIndicator({ emoji, - minature, + miniature, children, }: PropsWithChildren<{ - minature?: boolean; + miniature?: boolean; emoji: string; }>): ReactNode { return (
- + {emoji}
diff --git a/src/reactions/__snapshots__/RaisedHandIndicator.test.tsx.snap b/src/reactions/__snapshots__/RaisedHandIndicator.test.tsx.snap index 503631dc..91bde280 100644 --- a/src/reactions/__snapshots__/RaisedHandIndicator.test.tsx.snap +++ b/src/reactions/__snapshots__/RaisedHandIndicator.test.tsx.snap @@ -1,14 +1,14 @@ // Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html -exports[`RaisedHandIndicator > renders a smaller indicator when minature is specified 1`] = ` +exports[`RaisedHandIndicator > renders a smaller indicator when miniature is specified 1`] = `
✋ @@ -22,13 +22,13 @@ exports[`RaisedHandIndicator > renders a smaller indicator when minature is spec exports[`RaisedHandIndicator > renders an indicator when a hand has been raised 1`] = `
✋ @@ -42,13 +42,13 @@ exports[`RaisedHandIndicator > renders an indicator when a hand has been raised exports[`RaisedHandIndicator > renders an indicator when a hand has been raised with the expected time 1`] = `
✋ diff --git a/src/tile/MediaView.tsx b/src/tile/MediaView.tsx index 72348002..407f6961 100644 --- a/src/tile/MediaView.tsx +++ b/src/tile/MediaView.tsx @@ -100,12 +100,12 @@ export const MediaView = forwardRef(
{currentReaction && ( )}