diff --git a/.github/workflows/build-element-call.yaml b/.github/workflows/build-element-call.yaml index 838ef95bc..fb3484aca 100644 --- a/.github/workflows/build-element-call.yaml +++ b/.github/workflows/build-element-call.yaml @@ -14,17 +14,13 @@ on: description: The build mode for vite. Must be either 'development' or 'production' required: false default: production - secrets: - SENTRY_ORG: - required: true - SENTRY_PROJECT: - required: true - SENTRY_URL: - required: true - SENTRY_AUTH_TOKEN: - required: true - CODECOV_TOKEN: - required: false + # No `secrets:` block: every caller passes `secrets: inherit`, so the + # repository's secrets reach this workflow without each one being declared + # here and threaded through by name at the call sites -- the same pattern + # build-and-publish-docker.yaml uses. A secret this workflow starts using + # then needs no change to the callers. The ones read below are + # MATRIX_RTC_NPM_TOKEN, SENTRY_ORG, SENTRY_PROJECT, SENTRY_URL, + # SENTRY_AUTH_TOKEN and CODECOV_TOKEN. jobs: build: diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index babb65c94..142337712 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -15,12 +15,7 @@ jobs: package: full vite_app_version: ${{ github.event.release.tag_name || github.sha }} build_mode: ${{ github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'development build') && 'development' || 'production' }} - secrets: - SENTRY_ORG: ${{ secrets.SENTRY_ORG }} - SENTRY_PROJECT: ${{ secrets.SENTRY_PROJECT }} - SENTRY_URL: ${{ secrets.SENTRY_URL }} - SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }} - CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} + secrets: inherit deploy_develop: # Deploy main branch to call.element.dev after build completes if: github.ref == 'refs/heads/main' @@ -65,12 +60,7 @@ jobs: package: embedded vite_app_version: ${{ github.event.release.tag_name || github.sha }} build_mode: ${{ github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'development build') && 'development' || 'production' }} - secrets: - SENTRY_ORG: ${{ secrets.SENTRY_ORG }} - SENTRY_PROJECT: ${{ secrets.SENTRY_PROJECT }} - SENTRY_URL: ${{ secrets.SENTRY_URL }} - SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }} - CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} + secrets: inherit build_sdk_element_call: # Use the embedded package vite build @@ -79,12 +69,7 @@ jobs: package: sdk vite_app_version: ${{ github.event.release.tag_name || github.sha }} build_mode: ${{ github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'development build') && 'development' || 'production' }} - secrets: - SENTRY_ORG: ${{ secrets.SENTRY_ORG }} - SENTRY_PROJECT: ${{ secrets.SENTRY_PROJECT }} - SENTRY_URL: ${{ secrets.SENTRY_URL }} - SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }} - CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} + secrets: inherit build_storybook: name: Build Storybook diff --git a/.github/workflows/publish-embedded-packages.yaml b/.github/workflows/publish-embedded-packages.yaml index 2f1ef2974..6f07b3593 100644 --- a/.github/workflows/publish-embedded-packages.yaml +++ b/.github/workflows/publish-embedded-packages.yaml @@ -66,11 +66,7 @@ jobs: with: vite_app_version: embedded-${{ needs.versioning.outputs.PREFIXED_VERSION }} package: embedded - secrets: - SENTRY_ORG: ${{ secrets.SENTRY_ORG }} - SENTRY_PROJECT: ${{ secrets.SENTRY_PROJECT }} - SENTRY_URL: ${{ secrets.SENTRY_URL }} - SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }} + secrets: inherit publish_tarball: needs: [build_element_call, versioning] diff --git a/.github/workflows/publish.yaml b/.github/workflows/publish.yaml index 58e849759..d3566fa3d 100644 --- a/.github/workflows/publish.yaml +++ b/.github/workflows/publish.yaml @@ -13,11 +13,7 @@ jobs: with: package: full vite_app_version: ${{ github.event.release.tag_name }} # Using ${{ env.VERSION }} here doesn't work - secrets: - SENTRY_ORG: ${{ secrets.SENTRY_ORG }} - SENTRY_PROJECT: ${{ secrets.SENTRY_PROJECT }} - SENTRY_URL: ${{ secrets.SENTRY_URL }} - SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }} + secrets: inherit publish_tarball: needs: build_element_call