Commit Graph

14 Commits

Author SHA1 Message Date
David Baker
081c42f5bc Merge pull request #1892 from vector-im/dbkr/focus_switch_keep_screenshare
Keep screenshares when switching focus
2023-11-16 09:39:17 +00:00
David Baker
57ca5d1713 Another comment 2023-11-15 16:23:06 +00:00
David Baker
c146e83c15 Keep screenshares when switching focus
This also removes the use of the useLivekitRoom hook: we had reached
the point where the only thing it was actually doing was disconnecting,
so we now do that in the onClick handler for the leave button (I don't
think we need to disconnect on unmount?). It was otherwise just getting in
the way and causing tracks to be enabled/disabled when we didn't want them
to be. This also removes the need for the blockAudio code.

Fixes https://github.com/vector-im/element-call/issues/1413
2023-11-10 15:24:43 +00:00
David Baker
e4e721818a Close precreated tracks if we never add them
As the log line says, this should never happen, but if it does we
still shouldn't leak tracks.
2023-11-10 11:18:20 +00:00
David Baker
bc0d679d50 Add sentry message if we hit the extra mic check
If we hit the condition detecting that we're trying to add an extra
mic input, send a sentry message so we know if this is happening in
the wild.
2023-10-27 16:18:00 +01:00
David Baker
11664a5bf6 Prettier 2023-10-11 16:27:17 +01:00
David Baker
a9c74172a5 Add logging & guards for mic pre-creation & focus
Logs & guard for pre-recating the mic track as well as logging what
we select as the active focus (JWT URL + livekit alias).
2023-10-11 16:07:46 +01:00
Robin
614bc82402 Format code 2023-10-11 10:42:04 -04:00
Robin
a7624806b2 Upgrade eslint-plugin-matrix-org to 1.2.1
This upgrade came with a number of new lints that needed to be fixed across the code base. Primarily: explicit return types on functions, and explicit visibility modifiers on class members.
2023-09-22 18:07:06 -04:00
Robin
69bf3bd9a1 Fix double audio tracks
See comments. I'm not very happy with how this code bounces state in and out of different hooks and useEffect blocks, but as a quick fix this should work.
2023-09-20 13:26:34 -04:00
Timo
b979fc85bb Check for existing track before creating one. (#1459)
Signed-off-by: Timo K <toger5@hotmail.de>
2023-09-18 12:43:03 +02:00
David Baker
2c1692bd4f Always publish microphone track when joining 2023-09-08 17:22:02 +01:00
David Baker
b256755a0d Don't treat empty object as a valid sfu config
This was causing an extra reconnect cycle when the call was first
joined because it thought the previous SFU config was valid. This was
probably causing some client to fail to connect at all.
2023-08-31 09:44:23 +01:00
David Baker
4cd274b91e Manually disconnect & reconnect the livekit call if our focus changes
Without breaking the 'disconnected' screen
2023-08-29 12:45:34 +01:00