Commit Graph

11 Commits

Author SHA1 Message Date
Timo K
88e7eb8cf6 Merge branch 'livekit' into toger5/disable_audio_output_choice
Signed-off-by: Timo K <toger5@hotmail.de>
2023-09-19 15:12:26 +02:00
Timo
4aec5c34f3 Firefox audio output issues fix (#1510)
---------

Signed-off-by: Timo K <toger5@hotmail.de>
2023-09-19 15:10:14 +02:00
Timo K
6069e13348 commit to maybe help github to find its sanity again.
Signed-off-by: Timo K <toger5@hotmail.de>
2023-09-19 15:07:23 +02:00
Timo K
0af272ac46 improove comment
Signed-off-by: Timo K <toger5@hotmail.de>
2023-09-19 14:59:22 +02:00
Timo K
fdbc47fdd0 cannot use lk isFireFox
Signed-off-by: Timo K <toger5@hotmail.de>
2023-09-19 13:09:01 +02:00
Timo K
4120f34120 grammar...
Signed-off-by: Timo K <toger5@hotmail.de>
2023-09-19 12:43:02 +02:00
Timo K
7de9cfb5f2 ugh
Signed-off-by: Timo K <toger5@hotmail.de>
2023-09-19 12:42:33 +02:00
Timo K
02bf5f89e0 only on FF + code cleanup
Signed-off-by: Timo K <toger5@hotmail.de>
2023-09-19 12:40:53 +02:00
Timo K
8628123a53 disable audio output beeing anything else then undefined
Signed-off-by: Timo K <toger5@hotmail.de>
2023-09-19 12:13:45 +02:00
Robin
9db21e024e Start using the new modal component
This attempts to converge all our modals on the new modal component while changing their designs as little as possible. This should reduce the bundle size a bit and make the app generally feel like it's converging on the new designs, even though individual modals still remain to be revamped.
2023-09-17 14:46:36 -04:00
Robin Townsend
99ce5064f5 Fix multiple issues with device settings
To track media devices, we were previously relying on a combination of LiveKit's useMediaDeviceSelect hook, and an object called UserChoices. Device settings should be accessible from outside a call, but the latter hook should only be used with a room or set of preview tracks, so it couldn't be raised to the app's top level. I also felt that the UserChoices code was hard to follow due to lack of clear ownership of the object.

To bring clarity to media device handling and allow device settings to be shown outside a call, I refactored these things into a single MediaDevicesContext which is instantiated at the top level of the app. Then, I had to manually sync LiveKit's device state with whatever is present in the context. This refactoring ended up fixing a couple other bugs with device handling along the way.
2023-08-03 10:17:00 -04:00