mirror of
https://github.com/vector-im/element-call.git
synced 2026-08-29 21:15:19 +00:00
a1b37bb3c9
When someone starts or stops speaking, the layout will often be recomputed only to find out that there is ultimately no layout change. We can ignore these redundant updates to avoid re-rendering the InCallView and Grid components, which are relatively slow. For that specific, common case, this reduces JS CPU usage by as much as 70% in my testing.
75 lines
1.8 KiB
TypeScript
75 lines
1.8 KiB
TypeScript
/*
|
|
Copyright 2026 Element Creations Ltd.
|
|
|
|
SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial
|
|
Please see LICENSE in the repository root for full details.
|
|
*/
|
|
|
|
import { test, expect } from "vitest";
|
|
import {
|
|
type Alignment,
|
|
layoutShallowEquals,
|
|
type Layout,
|
|
} from "./layout-types";
|
|
import {
|
|
type SpotlightTileViewModel,
|
|
type GridTileViewModel,
|
|
} from "./TileViewModel";
|
|
import { BehaviorSubject } from "rxjs";
|
|
|
|
const spotlightTile = {} as unknown as SpotlightTileViewModel;
|
|
const gridTile = {} as unknown as GridTileViewModel;
|
|
const pipAlignment$ = new BehaviorSubject<Alignment>({
|
|
inline: "end",
|
|
block: "end",
|
|
});
|
|
|
|
const spotlightExpanded: Layout = {
|
|
type: "spotlight-expanded",
|
|
spotlight: spotlightTile,
|
|
pipAlignment$,
|
|
};
|
|
|
|
const spotlightPortrait: Layout = {
|
|
type: "spotlight-portrait",
|
|
spotlight: spotlightTile,
|
|
grid: [gridTile],
|
|
setVisibleTiles: () => {},
|
|
};
|
|
|
|
test("layoutShallowEquals considers a layout to be equal to its shallow clone", () =>
|
|
expect(layoutShallowEquals(spotlightExpanded, { ...spotlightExpanded })).toBe(
|
|
true,
|
|
));
|
|
|
|
test("layoutShallowEquals detects a missing key", () => {
|
|
expect(
|
|
layoutShallowEquals(spotlightExpanded, {
|
|
...spotlightExpanded,
|
|
pip: gridTile,
|
|
}),
|
|
).toBe(false);
|
|
expect(
|
|
layoutShallowEquals(
|
|
{ ...spotlightExpanded, pip: gridTile },
|
|
spotlightExpanded,
|
|
),
|
|
).toBe(false);
|
|
});
|
|
|
|
test("layoutShallowEquals considers grid arrays with equal contents to be equal", () =>
|
|
expect(
|
|
layoutShallowEquals(spotlightPortrait, {
|
|
...spotlightPortrait,
|
|
grid: [...spotlightPortrait.grid],
|
|
}),
|
|
).toBe(true));
|
|
|
|
test("layoutShallowEquals detects grid arrays with different contents", () =>
|
|
expect(
|
|
layoutShallowEquals(spotlightPortrait, {
|
|
...spotlightPortrait,
|
|
grid: [...spotlightPortrait.grid, gridTile],
|
|
}),
|
|
).toBe(false));
|