mirror of
https://github.com/vector-im/element-call.git
synced 2026-09-10 21:55:19 +00:00
The component exposed the internal HostBridge to hosts as-is, which carried the host's requests as rxjs observables. That made rxjs part of the public API of a package that bundles its own copy of it, so a host would build bridges with a different rxjs than the one Element Call consumed them with — and asked every host to learn rxjs to change the theme. A component host now implements plain async callbacks for what Element Call tells it (`ElementCallHostBridge`, all optional), and makes its own requests through an imperative handle on the component's `ref` (`ElementCallHandle`: setTheme, join, hangUp, setDeviceMute), each resolving once Element Call has acted and rejecting when nothing in Element Call can. `component/host.ts` adapts that to the HostBridge the rest of Element Call still speaks, with a bridge whose identity never changes, so a host re-creating its callbacks on render restarts nothing. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
123 lines
4.1 KiB
TypeScript
123 lines
4.1 KiB
TypeScript
/*
|
|
Copyright 2026 Element Creations Ltd.
|
|
|
|
SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial
|
|
Please see LICENSE in the repository root for full details.
|
|
*/
|
|
|
|
import { renderHook } from "@testing-library/react";
|
|
import { createRef } from "react";
|
|
import { describe, expect, test, vi } from "vitest";
|
|
|
|
import {
|
|
type ElementCallHandle,
|
|
type ElementCallHostBridge,
|
|
useComponentHostBridge,
|
|
} from "./host";
|
|
|
|
describe("useComponentHostBridge", () => {
|
|
test("keeps one identity while the host supplies new objects", () => {
|
|
const { result, rerender } = renderHook(
|
|
({ supplied }: { supplied: ElementCallHostBridge }) =>
|
|
useComponentHostBridge(supplied, undefined),
|
|
{ initialProps: { supplied: {} } },
|
|
);
|
|
const first = result.current;
|
|
rerender({ supplied: { notifyJoined: async () => {} } });
|
|
expect(result.current).toBe(first);
|
|
});
|
|
|
|
test("forwards to whatever the host most recently supplied", async () => {
|
|
const before = vi.fn().mockResolvedValue(undefined);
|
|
const after = vi.fn().mockResolvedValue(undefined);
|
|
const { result, rerender } = renderHook(
|
|
({ supplied }: { supplied: ElementCallHostBridge }) =>
|
|
useComponentHostBridge(supplied, undefined),
|
|
{ initialProps: { supplied: { notifyJoined: before } } },
|
|
);
|
|
rerender({ supplied: { notifyJoined: after } });
|
|
|
|
await result.current.notifyJoined();
|
|
expect(before).not.toHaveBeenCalled();
|
|
expect(after).toHaveBeenCalledOnce();
|
|
});
|
|
|
|
test("is quiet about what the host did not implement", async () => {
|
|
const { result } = renderHook(() =>
|
|
useComponentHostBridge(undefined, undefined),
|
|
);
|
|
await expect(result.current.contentLoaded()).resolves.toBeUndefined();
|
|
await expect(
|
|
result.current.notifyDeviceMute({
|
|
audio_enabled: true,
|
|
video_enabled: false,
|
|
}),
|
|
).resolves.toBeUndefined();
|
|
expect(result.current.supportsReactions).toBe(true);
|
|
});
|
|
|
|
test("only has a close when the host has one, since that is a signal", () => {
|
|
const { result, rerender } = renderHook(
|
|
({ supplied }: { supplied: ElementCallHostBridge }) =>
|
|
useComponentHostBridge(supplied, undefined),
|
|
{ initialProps: { supplied: {} } },
|
|
);
|
|
expect(result.current.close).toBeUndefined();
|
|
|
|
const close = vi.fn().mockResolvedValue(undefined);
|
|
rerender({ supplied: { close } });
|
|
expect(result.current.close).toBeDefined();
|
|
});
|
|
|
|
test("never offers profile changes, since the account is the host's", () => {
|
|
const { result } = renderHook(() =>
|
|
useComponentHostBridge(undefined, undefined),
|
|
);
|
|
expect(result.current.supportsProfileChanges).toBe(false);
|
|
});
|
|
|
|
describe("the handle", () => {
|
|
test("delivers a request to what is listening and resolves on its reply", async () => {
|
|
const ref = createRef<ElementCallHandle>();
|
|
const { result } = renderHook(() =>
|
|
useComponentHostBridge(undefined, ref),
|
|
);
|
|
|
|
const received = vi.fn();
|
|
result.current.deviceMute$.subscribe(({ data, reply }) => {
|
|
received(data);
|
|
reply({ audio_enabled: data.audio_enabled!, video_enabled: true });
|
|
});
|
|
|
|
await expect(
|
|
ref.current!.setDeviceMute({ audio_enabled: false }),
|
|
).resolves.toEqual({ audio_enabled: false, video_enabled: true });
|
|
expect(received).toHaveBeenCalledWith({ audio_enabled: false });
|
|
});
|
|
|
|
test("refuses a request nothing in Element Call is listening for", async () => {
|
|
const ref = createRef<ElementCallHandle>();
|
|
renderHook(() => useComponentHostBridge(undefined, ref));
|
|
|
|
await expect(ref.current!.hangUp()).rejects.toThrow(
|
|
"Nothing in Element Call can hang up right now",
|
|
);
|
|
});
|
|
|
|
test("passes the theme name through", async () => {
|
|
const ref = createRef<ElementCallHandle>();
|
|
const { result } = renderHook(() =>
|
|
useComponentHostBridge(undefined, ref),
|
|
);
|
|
const names: (string | undefined)[] = [];
|
|
result.current.themeChange$.subscribe(({ data, reply }) => {
|
|
names.push(data.name);
|
|
reply();
|
|
});
|
|
|
|
await ref.current!.setTheme("light");
|
|
expect(names).toEqual(["light"]);
|
|
});
|
|
});
|
|
});
|