mirror of
https://github.com/vector-im/element-call.git
synced 2026-01-30 03:15:55 +00:00
b0587fcfb3
* Avoid reactivity bugs in how we track external state
Many of our hooks which attempt to bridge external state from an EventEmitter or EventTarget into React had subtle bugs which could cause them to fail to react to certain updates. The conditions necessary for triggering these bugs are explained by the tests that I've included.
In the majority of cases, I don't think we were triggering these bugs in practice. They could've become problems if we refactored our components in certain ways. The one concrete case I'm aware of in which we actually triggered such a bug was the race condition with the useRoomEncryptionSystem shared secret logic (addressed by a1110af6d5).
But, particularly with all the weird reactivity issues we're debugging this week, I think we need to eliminate the possibility that any of the bugs in these hooks are the cause of our current headaches.
* Reuse useTypedEventEmitterState in useLocalStorage
* Fix type error
52 lines
1.5 KiB
TypeScript
52 lines
1.5 KiB
TypeScript
/*
|
|
Copyright 2025 New Vector Ltd.
|
|
|
|
SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial
|
|
Please see LICENSE in the repository root for full details.
|
|
*/
|
|
|
|
import { test } from "vitest";
|
|
import { render, screen } from "@testing-library/react";
|
|
import { type FC, useEffect, useState } from "react";
|
|
import userEvent from "@testing-library/user-event";
|
|
|
|
import {
|
|
setLocalStorageItemReactive,
|
|
useLocalStorage,
|
|
} from "./useLocalStorage";
|
|
|
|
test("useLocalStorage reacts to changes made by an effect mounted on the same render", () => {
|
|
localStorage.clear();
|
|
const Test: FC = () => {
|
|
useEffect(() => setLocalStorageItemReactive("my-value", "Hello!"), []);
|
|
const [myValue] = useLocalStorage("my-value");
|
|
return myValue;
|
|
};
|
|
render(<Test />);
|
|
screen.getByText("Hello!");
|
|
});
|
|
|
|
test("useLocalStorage reacts to key changes", async () => {
|
|
localStorage.clear();
|
|
localStorage.setItem("value-1", "1");
|
|
localStorage.setItem("value-2", "2");
|
|
|
|
const Test: FC = () => {
|
|
const [key, setKey] = useState("value-1");
|
|
const [value] = useLocalStorage(key);
|
|
if (key !== `value-${value}`) throw new Error("Value is out of sync");
|
|
return (
|
|
<>
|
|
<button onClick={() => setKey("value-2")}>Switch keys</button>
|
|
<div>Value is: {value}</div>
|
|
</>
|
|
);
|
|
};
|
|
const user = userEvent.setup();
|
|
render(<Test />);
|
|
|
|
screen.getByText("Value is: 1");
|
|
await user.click(screen.getByRole("button", { name: "Switch keys" }));
|
|
screen.getByText("Value is: 2");
|
|
});
|