mirror of
https://github.com/vector-im/element-call.git
synced 2026-05-22 11:04:38 +00:00
* Posthog: drop $initial_person_info from outgoing events * Posthog: migrate from sanitize_properties to before_send * strip URL fields from $set / $set_once * enable mask_personal_data_properties * review * update tests to check for `delete` (not anymore `=null`) rename: `applyPrivacyFilters`->`santizeSensitiveData` --------- Co-authored-by: Timo K <toger5@hotmail.de>
247 lines
7.4 KiB
TypeScript
247 lines
7.4 KiB
TypeScript
/*
|
|
Copyright 2025 New Vector Ltd.
|
|
|
|
SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial
|
|
Please see LICENSE in the repository root for full details.
|
|
*/
|
|
|
|
import {
|
|
expect,
|
|
describe,
|
|
it,
|
|
vi,
|
|
beforeEach,
|
|
beforeAll,
|
|
afterAll,
|
|
} from "vitest";
|
|
import posthog, { type CaptureResult } from "posthog-js";
|
|
|
|
import {
|
|
Anonymity,
|
|
santizeSensitiveData,
|
|
PosthogAnalytics,
|
|
} from "./PosthogAnalytics";
|
|
import { mockConfig } from "../utils/test";
|
|
|
|
describe("PosthogAnalytics", () => {
|
|
describe("embedded package", () => {
|
|
beforeAll(() => {
|
|
vi.stubEnv("VITE_PACKAGE", "embedded");
|
|
});
|
|
|
|
beforeEach(() => {
|
|
mockConfig({});
|
|
window.location.hash = "#";
|
|
PosthogAnalytics.resetInstance();
|
|
});
|
|
|
|
afterAll(() => {
|
|
vi.unstubAllEnvs();
|
|
});
|
|
|
|
it("does not create instance without config value or URL params", () => {
|
|
expect(PosthogAnalytics.instance.isEnabled()).toBe(false);
|
|
});
|
|
|
|
it("ignores config value and does not create instance", () => {
|
|
mockConfig({
|
|
posthog: {
|
|
api_host: "https://api.example.com.localhost",
|
|
api_key: "api_key",
|
|
},
|
|
});
|
|
expect(PosthogAnalytics.instance.isEnabled()).toBe(false);
|
|
});
|
|
|
|
it("uses URL params if both set", () => {
|
|
window.location.hash = `#?posthogApiHost=${encodeURIComponent("https://url.example.com.localhost")}&posthogApiKey=api_key`;
|
|
expect(PosthogAnalytics.instance.isEnabled()).toBe(true);
|
|
});
|
|
});
|
|
|
|
describe("full package", () => {
|
|
beforeAll(() => {
|
|
vi.stubEnv("VITE_PACKAGE", "full");
|
|
});
|
|
|
|
beforeEach(() => {
|
|
mockConfig({});
|
|
window.location.hash = "#";
|
|
PosthogAnalytics.resetInstance();
|
|
});
|
|
|
|
afterAll(() => {
|
|
vi.unstubAllEnvs();
|
|
});
|
|
|
|
it("does not create instance without config value", () => {
|
|
expect(PosthogAnalytics.instance.isEnabled()).toBe(false);
|
|
});
|
|
|
|
it("ignores URL params and does not create instance", () => {
|
|
window.location.hash = `#?posthogApiHost=${encodeURIComponent("https://url.example.com.localhost")}&posthogApiKey=api_key`;
|
|
expect(PosthogAnalytics.instance.isEnabled()).toBe(false);
|
|
});
|
|
|
|
it("creates instance with config value", () => {
|
|
mockConfig({
|
|
posthog: {
|
|
api_host: "https://api.example.com.localhost",
|
|
api_key: "api_key",
|
|
},
|
|
});
|
|
expect(PosthogAnalytics.instance.isEnabled()).toBe(true);
|
|
});
|
|
});
|
|
|
|
describe("applyPrivacyFilters", () => {
|
|
const makeEvent = (properties: Record<string, unknown>): CaptureResult =>
|
|
({ event: "anyEvent", properties }) as unknown as CaptureResult;
|
|
|
|
it("drops $initial_person_info regardless of anonymity", () => {
|
|
const out = santizeSensitiveData(
|
|
makeEvent({
|
|
$current_url: "https://call.example.com/some/private/path",
|
|
$initial_person_info: {
|
|
r: "https://example.com/referrer",
|
|
u: "https://call.example.com/some/private/path",
|
|
},
|
|
}),
|
|
Anonymity.Pseudonymous,
|
|
);
|
|
expect(out?.properties).not.toHaveProperty("$initial_person_info");
|
|
});
|
|
|
|
it("strips hash from $current_url", () => {
|
|
const out = santizeSensitiveData(
|
|
makeEvent({ $current_url: "https://call.example.com/#/x/y/z" }),
|
|
Anonymity.Pseudonymous,
|
|
);
|
|
expect(out?.properties["$current_url"]).not.toContain("/x/y/z");
|
|
});
|
|
|
|
it("nulls referrer and device fields when anonymous", () => {
|
|
const out = santizeSensitiveData(
|
|
makeEvent({
|
|
$current_url: "https://x/y",
|
|
$referrer: "https://leaky",
|
|
$initial_referrer: "https://leaky-too",
|
|
$device_id: "uuid",
|
|
}),
|
|
Anonymity.Anonymous,
|
|
);
|
|
expect(out?.properties["$referrer"]).toBeUndefined();
|
|
expect(out?.properties["$initial_referrer"]).toBeUndefined();
|
|
expect(out?.properties["$device_id"]).toBeUndefined();
|
|
});
|
|
|
|
it("passes null events through unchanged", () => {
|
|
expect(santizeSensitiveData(null, Anonymity.Pseudonymous)).toBeNull();
|
|
});
|
|
|
|
it("strips URL fields nested inside $set_once", () => {
|
|
const secretUrl =
|
|
"https://call.example.com/room/#/?password=hunter2&roomId=abc";
|
|
const out = santizeSensitiveData(
|
|
makeEvent({
|
|
$current_url: "https://call.example.com/x",
|
|
$set_once: {
|
|
$current_url: secretUrl,
|
|
$initial_current_url: secretUrl,
|
|
$session_entry_url: secretUrl,
|
|
$initial_person_info: { r: "x", u: secretUrl },
|
|
},
|
|
}),
|
|
Anonymity.Pseudonymous,
|
|
);
|
|
|
|
const setOnce = out?.properties["$set_once"] as Record<string, unknown>;
|
|
expect(setOnce["$current_url"]).not.toContain("password");
|
|
expect(setOnce["$initial_current_url"]).not.toContain("password");
|
|
expect(setOnce).not.toHaveProperty("$session_entry_url");
|
|
expect(setOnce).not.toHaveProperty("$initial_person_info");
|
|
});
|
|
|
|
it("strips URL fields nested inside $set", () => {
|
|
const secretUrl =
|
|
"https://call.example.com/room/#/?password=hunter2&roomId=abc";
|
|
const out = santizeSensitiveData(
|
|
makeEvent({
|
|
$current_url: "https://call.example.com/x",
|
|
$set: {
|
|
$current_url: secretUrl,
|
|
$session_entry_url: secretUrl,
|
|
},
|
|
}),
|
|
Anonymity.Pseudonymous,
|
|
);
|
|
|
|
const set = out?.properties["$set"] as Record<string, unknown>;
|
|
expect(set["$current_url"]).not.toContain("password");
|
|
expect(set).not.toHaveProperty("$session_entry_url");
|
|
});
|
|
|
|
it("nulls referrer fields inside $set_once when anonymous", () => {
|
|
const out = santizeSensitiveData(
|
|
makeEvent({
|
|
$current_url: "https://x/y",
|
|
$set_once: {
|
|
$initial_referrer: "https://leaky",
|
|
$initial_referring_domain: "leaky",
|
|
},
|
|
}),
|
|
Anonymity.Anonymous,
|
|
);
|
|
|
|
const setOnce = out?.properties["$set_once"] as Record<string, unknown>;
|
|
expect(setOnce["$initial_referrer"]).toBeUndefined();
|
|
expect(setOnce["$initial_referring_domain"]).toBeUndefined();
|
|
});
|
|
});
|
|
|
|
// Verifies that applyPrivacyFilters is actually wired into posthog.init via
|
|
// the before_send hook — guards against typos in the option name or future
|
|
// posthog-js bumps renaming/removing the hook. The filter logic itself is
|
|
// covered by the applyPrivacyFilters block above.
|
|
describe("posthog.init wiring", () => {
|
|
beforeAll(() => {
|
|
vi.stubEnv("VITE_PACKAGE", "full");
|
|
});
|
|
|
|
beforeEach(() => {
|
|
mockConfig({
|
|
posthog: {
|
|
api_host: "https://api.example.com.localhost",
|
|
api_key: "api_key",
|
|
},
|
|
});
|
|
PosthogAnalytics.resetInstance();
|
|
});
|
|
|
|
afterAll(() => {
|
|
vi.unstubAllEnvs();
|
|
});
|
|
|
|
it("passes events through the privacy filter via before_send", () => {
|
|
const initSpy = vi.spyOn(posthog, "init");
|
|
expect(PosthogAnalytics.instance.isEnabled()).toBe(true);
|
|
|
|
const beforeSend = initSpy.mock.calls[0][1]?.before_send;
|
|
expect(beforeSend).toBeInstanceOf(Function);
|
|
|
|
const event = {
|
|
event: "anyEvent",
|
|
properties: {
|
|
$current_url: "https://call.example.com/x/y",
|
|
$initial_person_info: { r: "x" },
|
|
},
|
|
} as unknown as CaptureResult;
|
|
|
|
const out = (beforeSend as (e: CaptureResult) => CaptureResult | null)(
|
|
event,
|
|
);
|
|
expect(out?.properties).not.toHaveProperty("$initial_person_info");
|
|
});
|
|
});
|
|
});
|