From 81f60959e59901e8f412d9f13a83f17aee62a230 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Garc=C3=ADa=20Aubert?=
 <danielgarciaaubert@gmail.com>
Date: Wed, 14 Jun 2017 19:20:39 +0200
Subject: [PATCH] Going green: handle special float values for formula when
 overviews are involved

---
 .../models/dataview/overviews/formula.js      | 28 ++++++++++++++++---
 1 file changed, 24 insertions(+), 4 deletions(-)

diff --git a/lib/cartodb/models/dataview/overviews/formula.js b/lib/cartodb/models/dataview/overviews/formula.js
index 9e331f0b..ba98b2c8 100644
--- a/lib/cartodb/models/dataview/overviews/formula.js
+++ b/lib/cartodb/models/dataview/overviews/formula.js
@@ -14,14 +14,34 @@ var formulaQueryTpls = {
   'sum': dot.template([
       'SELECT',
       'sum({{=it._column}}*_feature_count) AS result,',
-      '(SELECT count(1) FROM ({{=it._query}}) _cdb_formula_nulls WHERE {{=it._column}} IS NULL) AS nulls_count',
-      'FROM ({{=it._query}}) _cdb_formula'
+      '(SELECT count(1) FROM ({{=it._query}}) _cdb_formula_nulls WHERE {{=it._column}} IS NULL) AS nulls_count,',
+      '(SELECT count(1) FROM ({{=it._query}}) _cdb_formula_infinities',
+      '  WHERE {{=it._column}} = \'infinity\'::float OR {{=it._column}} = \'-infinity\'::float) AS infinities_count,',
+      '(SELECT count(1) FROM ({{=it._query}}) _cdb_formula_nans',
+      '  WHERE {{=it._column}} = \'NaN\'::float) AS nans_count',
+      'FROM ({{=it._query}}) _cdb_formula',
+      'WHERE',
+      '  {{=it._column}} != \'infinity\'::float',
+      'AND',
+      '  {{=it._column}} != \'-infinity\'::float',
+      'AND',
+      '  {{=it._column}} != \'NaN\'::float'
   ].join('\n')),
   'avg': dot.template([
       'SELECT',
       'sum({{=it._column}}*_feature_count)/sum(_feature_count) AS result,',
-      '(SELECT count(1) FROM ({{=it._query}}) _cdb_formula_nulls WHERE {{=it._column}} IS NULL) AS nulls_count',
-      'FROM ({{=it._query}}) _cdb_formula'
+      '(SELECT count(1) FROM ({{=it._query}}) _cdb_formula_nulls WHERE {{=it._column}} IS NULL) AS nulls_count,',
+      '(SELECT count(1) FROM ({{=it._query}}) _cdb_formula_infinities',
+      '  WHERE {{=it._column}} = \'infinity\'::float OR {{=it._column}} = \'-infinity\'::float) AS infinities_count,',
+      '(SELECT count(1) FROM ({{=it._query}}) _cdb_formula_nans',
+      '  WHERE {{=it._column}} = \'NaN\'::float) AS nans_count',
+      'FROM ({{=it._query}}) _cdb_formula',
+      'WHERE',
+      '  {{=it._column}} != \'infinity\'::float',
+      'AND',
+      '  {{=it._column}} != \'-infinity\'::float',
+      'AND',
+      '  {{=it._column}} != \'NaN\'::float'
   ].join('\n')),
 };