From 09568050d60a077a54d485facabc3849c7085cc3 Mon Sep 17 00:00:00 2001
From: Javier Goizueta <jgoizueta@gmail.com>
Date: Wed, 20 Jan 2016 13:13:02 +0100
Subject: [PATCH] Fix for changes in pgQueryRunner

---
 lib/cartodb/api/overviews_api.js | 33 +++++++++++++-------------------
 1 file changed, 13 insertions(+), 20 deletions(-)

diff --git a/lib/cartodb/api/overviews_api.js b/lib/cartodb/api/overviews_api.js
index 4ccb28ce..9b6dc1c6 100644
--- a/lib/cartodb/api/overviews_api.js
+++ b/lib/cartodb/api/overviews_api.js
@@ -14,6 +14,7 @@ function OverviewsApi(pgQueryRunner) {
 module.exports = OverviewsApi;
 
 OverviewsApi.prototype.getOverviewsMetadata = function (username, sql, callback) {
+    var self = this;
     this.queryTablesApi.getAffectedTablesInQuery(username, sql, function(err, tableNames){
         if (err) {
             callback(err);
@@ -26,13 +27,19 @@ OverviewsApi.prototype.getOverviewsMetadata = function (username, sql, callback)
             tableNames.forEach(function(tableName) {
                 q.defer(function(done){
                     var query = "SELECT * FROM CDB_Overviews('" + tableName + "');";
-                    this.pgQueryRunner.run(username, query, handleOverviewsRows, function(err, table_metadata){
-                        if (err) {
-                            done(err);
-                        } else {
-                            metadata[tableName] = table_metadata;
-                            done(null);
+                    self.pgQueryRunner.run(username, query, function handleOverviewsRows(err, rows) {
+                        if (err){
+                            var msg = err.message ? err.message : err;
+                            done(new Error('could not get overviews metadata: ' + msg));
+                            return;
                         }
+                        var table_metadata = {};
+                        for ( var i=0; i<rows.length; ++i ) {
+                          var row = rows[i];
+                          table_metadata[row.z] = { table: row.overview_table };
+                        }
+                        metadata[tableName] = table_metadata;
+                        done(null);
                     });
                 });
             });
@@ -47,17 +54,3 @@ OverviewsApi.prototype.getOverviewsMetadata = function (username, sql, callback)
         }
     });
 };
-
-function handleOverviewsRows(err, rows, callback) {
-    if (err){
-        var msg = err.message ? err.message : err;
-        callback(new Error('could not get overviews metadata: ' + msg));
-        return;
-    }
-    var metadata = {};
-    for ( var i=0; i<rows.length; ++i ) {
-      var row = rows[i];
-      metadata[row.z] = { table: row.overview_table };
-    }
-    callback(null, metadata);
-}