Replace assert.equal() by assert.strictEqual()

This commit is contained in:
Daniel García Aubert
2019-10-21 19:41:03 +02:00
parent 4d70ac0894
commit 1bee877b24
100 changed files with 1100 additions and 1100 deletions
@@ -55,10 +55,10 @@ describe('analysis-backend limits', function () {
assert.ok(!err, err);
assert.ok(result.analyses.moran);
assert.equal(result.analyses.moran.timeout, 5000);
assert.strictEqual(result.analyses.moran.timeout, 5000);
assert.ok(result.analyses.kmeans);
assert.equal(result.analyses.kmeans.timeout, 5000);
assert.strictEqual(result.analyses.kmeans.timeout, 5000);
done();
});
@@ -78,7 +78,7 @@ describe('analysis-backend limits', function () {
assert.ok(!err, err);
assert.ok(result.analyses.moran);
assert.equal(result.analyses.moran.timeout, 5000);
assert.strictEqual(result.analyses.moran.timeout, 5000);
done();
});
@@ -103,7 +103,7 @@ describe('analysis-backend limits', function () {
assert.ok(!err, err);
assert.ok(result.analyses.moran);
assert.equal(result.analyses.moran.timeout, 5000);
assert.strictEqual(result.analyses.moran.timeout, 5000);
done();
});
@@ -129,10 +129,10 @@ describe('analysis-backend limits', function () {
assert.ok(!err, err);
assert.ok(result.analyses.moran);
assert.equal(result.analyses.moran.timeout, 5000);
assert.strictEqual(result.analyses.moran.timeout, 5000);
assert.ok(result.analyses.kmeans);
assert.equal(result.analyses.kmeans.timeout, 1000);
assert.strictEqual(result.analyses.kmeans.timeout, 1000);
done();
});
@@ -157,8 +157,8 @@ describe('analysis-backend limits', function () {
assert.ok(!err, err);
assert.ok(result.analyses['aggregate-intersection']);
assert.equal(result.analyses['aggregate-intersection'].timeout, 5000);
assert.equal(result.analyses['aggregate-intersection'].maxNumberOfRows, 1e5);
assert.strictEqual(result.analyses['aggregate-intersection'].timeout, 5000);
assert.strictEqual(result.analyses['aggregate-intersection'].maxNumberOfRows, 1e5);
done();
});
@@ -143,10 +143,10 @@ describe('named_layers datasources', function () {
config: makeNamedMapLayerConfig([wadusLayer]),
test: function (err, layers, datasource, done) {
assert.ok(!err);
assert.equal(layers.length, 1);
assert.strictEqual(layers.length, 1);
assert.equal(layers[0].type, 'cartodb');
assert.equal(layers[0].options.sql, wadusSql);
assert.strictEqual(layers[0].type, 'cartodb');
assert.strictEqual(layers[0].options.sql, wadusSql);
assert.deepEqual(datasource.getLayerDatasource(0), {});
done();
@@ -158,14 +158,14 @@ describe('named_layers datasources', function () {
config: makeNamedMapLayerConfig([wadusLayer, simpleNamedLayer]),
test: function (err, layers, datasource, done) {
assert.ok(!err);
assert.equal(layers.length, 2);
assert.strictEqual(layers.length, 2);
assert.equal(layers[0].type, 'cartodb');
assert.equal(layers[0].options.sql, wadusSql);
assert.strictEqual(layers[0].type, 'cartodb');
assert.strictEqual(layers[0].options.sql, wadusSql);
assert.deepEqual(datasource.getLayerDatasource(0), {});
assert.equal(layers[1].type, 'cartodb');
assert.equal(layers[1].options.sql, wadusTemplateSql);
assert.strictEqual(layers[1].type, 'cartodb');
assert.strictEqual(layers[1].options.sql, wadusTemplateSql);
var layerDatasource = datasource.getLayerDatasource(1);
assert.notEqual(layerDatasource, undefined);
assert.ok(layerDatasource.user);
@@ -179,20 +179,20 @@ describe('named_layers datasources', function () {
config: makeNamedMapLayerConfig([wadusLayer, multipleLayersNamedLayer]),
test: function (err, layers, datasource, done) {
assert.ok(!err);
assert.equal(layers.length, 3);
assert.strictEqual(layers.length, 3);
assert.equal(layers[0].type, 'cartodb');
assert.equal(layers[0].options.sql, wadusSql);
assert.strictEqual(layers[0].type, 'cartodb');
assert.strictEqual(layers[0].options.sql, wadusSql);
assert.deepEqual(datasource.getLayerDatasource(0), {});
assert.equal(layers[1].type, 'mapnik');
assert.equal(layers[1].options.sql, wadusMapnikSql);
assert.strictEqual(layers[1].type, 'mapnik');
assert.strictEqual(layers[1].options.sql, wadusMapnikSql);
var layerDatasource = datasource.getLayerDatasource(1);
assert.notEqual(layerDatasource, undefined);
assert.ok(layerDatasource.user);
assert.equal(layers[2].type, 'cartodb');
assert.equal(layers[2].options.sql, wadusTemplateSql);
assert.strictEqual(layers[2].type, 'cartodb');
assert.strictEqual(layers[2].options.sql, wadusTemplateSql);
layerDatasource = datasource.getLayerDatasource(2);
assert.notEqual(layerDatasource, undefined);
assert.ok(layerDatasource.user);
@@ -206,22 +206,22 @@ describe('named_layers datasources', function () {
config: makeNamedMapLayerConfig([multipleLayersNamedLayer, simpleNamedLayer]),
test: function (err, layers, datasource, done) {
assert.ok(!err);
assert.equal(layers.length, 3);
assert.strictEqual(layers.length, 3);
assert.equal(layers[0].type, 'mapnik');
assert.equal(layers[0].options.sql, wadusMapnikSql);
assert.strictEqual(layers[0].type, 'mapnik');
assert.strictEqual(layers[0].options.sql, wadusMapnikSql);
var layerDatasource = datasource.getLayerDatasource(0);
assert.notEqual(layerDatasource, undefined);
assert.ok(layerDatasource.user);
assert.equal(layers[1].type, 'cartodb');
assert.equal(layers[1].options.sql, wadusTemplateSql);
assert.strictEqual(layers[1].type, 'cartodb');
assert.strictEqual(layers[1].options.sql, wadusTemplateSql);
layerDatasource = datasource.getLayerDatasource(1);
assert.notEqual(layerDatasource, undefined);
assert.ok(layerDatasource.user);
assert.equal(layers[2].type, 'cartodb');
assert.equal(layers[2].options.sql, wadusTemplateSql);
assert.strictEqual(layers[2].type, 'cartodb');
assert.strictEqual(layers[2].options.sql, wadusTemplateSql);
layerDatasource = datasource.getLayerDatasource(2);
assert.notEqual(layerDatasource, undefined);
assert.ok(layerDatasource.user);
@@ -242,48 +242,48 @@ describe('named_layers datasources', function () {
]),
test: function (err, layers, datasource, done) {
assert.ok(!err);
assert.equal(layers.length, 8);
assert.strictEqual(layers.length, 8);
assert.equal(layers[0].type, 'cartodb');
assert.equal(layers[0].options.sql, wadusTemplateSql);
assert.strictEqual(layers[0].type, 'cartodb');
assert.strictEqual(layers[0].options.sql, wadusTemplateSql);
var layerDatasource = datasource.getLayerDatasource(0);
assert.notEqual(layerDatasource, undefined);
assert.ok(layerDatasource.user);
assert.equal(layers[1].type, 'mapnik');
assert.equal(layers[1].options.sql, wadusMapnikSql);
assert.strictEqual(layers[1].type, 'mapnik');
assert.strictEqual(layers[1].options.sql, wadusMapnikSql);
layerDatasource = datasource.getLayerDatasource(1);
assert.notEqual(layerDatasource, undefined);
assert.ok(layerDatasource.user);
assert.equal(layers[2].type, 'cartodb');
assert.equal(layers[2].options.sql, wadusTemplateSql);
assert.strictEqual(layers[2].type, 'cartodb');
assert.strictEqual(layers[2].options.sql, wadusTemplateSql);
layerDatasource = datasource.getLayerDatasource(2);
assert.notEqual(layerDatasource, undefined);
assert.ok(layerDatasource.user);
assert.equal(layers[3].type, 'cartodb');
assert.equal(layers[3].options.sql, wadusSql);
assert.strictEqual(layers[3].type, 'cartodb');
assert.strictEqual(layers[3].options.sql, wadusSql);
assert.deepEqual(datasource.getLayerDatasource(3), {});
assert.equal(layers[4].type, 'cartodb');
assert.equal(layers[4].options.sql, wadusTemplateSql);
assert.strictEqual(layers[4].type, 'cartodb');
assert.strictEqual(layers[4].options.sql, wadusTemplateSql);
layerDatasource = datasource.getLayerDatasource(4);
assert.notEqual(layerDatasource, undefined);
assert.ok(layerDatasource.user);
assert.equal(layers[5].type, 'cartodb');
assert.equal(layers[5].options.sql, wadusSql);
assert.strictEqual(layers[5].type, 'cartodb');
assert.strictEqual(layers[5].options.sql, wadusSql);
assert.deepEqual(datasource.getLayerDatasource(5), {});
assert.equal(layers[6].type, 'mapnik');
assert.equal(layers[6].options.sql, wadusMapnikSql);
assert.strictEqual(layers[6].type, 'mapnik');
assert.strictEqual(layers[6].options.sql, wadusMapnikSql);
layerDatasource = datasource.getLayerDatasource(6);
assert.notEqual(layerDatasource, undefined);
assert.ok(layerDatasource.user);
assert.equal(layers[7].type, 'cartodb');
assert.equal(layers[7].options.sql, wadusTemplateSql);
assert.strictEqual(layers[7].type, 'cartodb');
assert.strictEqual(layers[7].options.sql, wadusTemplateSql);
layerDatasource = datasource.getLayerDatasource(7);
assert.notEqual(layerDatasource, undefined);
assert.ok(layerDatasource.user);
@@ -155,7 +155,7 @@ describe('mapconfig-named-layers-adapter', function () {
assert.ok(err);
assert.ok(!mapConfig);
assert.ok(!context.datasource);
assert.equal(err.message, 'Missing Named Map `name` in layer options');
assert.strictEqual(err.message, 'Missing Named Map `name` in layer options');
done();
}
@@ -172,7 +172,7 @@ describe('mapconfig-named-layers-adapter', function () {
assert.ok(err);
assert.ok(!mapConfig);
assert.ok(!context.datasource);
assert.equal(
assert.strictEqual(
err.message, "Template '" + missingTemplateName + "' of user '" + username + "' not found"
);
@@ -195,7 +195,7 @@ describe('mapconfig-named-layers-adapter', function () {
assert.ok(err);
assert.ok(!mapConfig);
assert.ok(!context.datasource);
assert.equal(err.message, "Unauthorized '" + tokenAuthTemplateName + "' template instantiation");
assert.strictEqual(err.message, "Unauthorized '" + tokenAuthTemplateName + "' template instantiation");
templateMaps.delTemplate(username, tokenAuthTemplateName, done);
}
@@ -217,7 +217,7 @@ describe('mapconfig-named-layers-adapter', function () {
assert.ok(err);
assert.ok(!mapConfig);
assert.ok(!context.datasource);
assert.equal(err.message, 'Nested named layers are not allowed');
assert.strictEqual(err.message, 'Nested named layers are not allowed');
templateMaps.delTemplate(username, nestedNamedMapTemplateName, done);
}
@@ -256,7 +256,7 @@ describe('mapconfig-named-layers-adapter', function () {
function (err, mapConfig) {
assert.ok(!err);
var layers = mapConfig.layers;
assert.equal(layers.length, 1);
assert.strictEqual(layers.length, 1);
assert.notEqual(context.datasource.getLayerDatasource(0), undefined);
templateMaps.delTemplate(username, tokenAuthTemplateName, done);
@@ -279,14 +279,14 @@ describe('mapconfig-named-layers-adapter', function () {
function (err, mapConfig) {
assert.ok(!err);
var layers = mapConfig.layers;
assert.equal(layers.length, 2);
assert.strictEqual(layers.length, 2);
assert.equal(layers[0].type, 'mapnik');
assert.equal(layers[0].options.cartocss, '#layer { polygon-fill: green; }');
assert.strictEqual(layers[0].type, 'mapnik');
assert.strictEqual(layers[0].options.cartocss, '#layer { polygon-fill: green; }');
assert.notEqual(context.datasource.getLayerDatasource(0), undefined);
assert.equal(layers[1].type, 'cartodb');
assert.equal(layers[1].options.cartocss, '#layer { marker-fill: red; }');
assert.strictEqual(layers[1].type, 'cartodb');
assert.strictEqual(layers[1].options.cartocss, '#layer { marker-fill: red; }');
assert.notEqual(context.datasource.getLayerDatasource(1), undefined);
templateMaps.delTemplate(username, multipleLayersTemplateName, done);
@@ -316,14 +316,14 @@ describe('mapconfig-named-layers-adapter', function () {
function (err, mapConfig) {
assert.ok(!err);
var layers = mapConfig.layers;
assert.equal(layers.length, 2);
assert.strictEqual(layers.length, 2);
assert.equal(layers[0].type, 'mapnik');
assert.equal(layers[0].options.cartocss, '#layer { polygon-fill: ' + polygonColor + '; }');
assert.strictEqual(layers[0].type, 'mapnik');
assert.strictEqual(layers[0].options.cartocss, '#layer { polygon-fill: ' + polygonColor + '; }');
assert.notEqual(context.datasource.getLayerDatasource(0), undefined);
assert.equal(layers[1].type, 'cartodb');
assert.equal(layers[1].options.cartocss, '#layer { marker-fill: ' + color + '; }');
assert.strictEqual(layers[1].type, 'cartodb');
assert.strictEqual(layers[1].options.cartocss, '#layer { marker-fill: ' + color + '; }');
assert.notEqual(context.datasource.getLayerDatasource(1), undefined);
templateMaps.delTemplate(username, multipleLayersTemplateName, done);
@@ -44,12 +44,12 @@ describe('MapConfigOverviewsAdapter', function () {
mapConfigOverviewsAdapter.getMapConfig('localhost', _mapConfig, params, context, function (err, mapConfig) {
assert.ok(!err);
var layers = mapConfig.layers;
assert.equal(layers.length, 1);
assert.equal(layers[0].type, 'cartodb');
assert.equal(layers[0].options.sql, sql);
assert.equal(layers[0].options.cartocss, cartocss);
assert.equal(layers[0].options.cartocss_version, cartocss_version);
assert.equal(layers[0].options.overviews, undefined);
assert.strictEqual(layers.length, 1);
assert.strictEqual(layers[0].type, 'cartodb');
assert.strictEqual(layers[0].options.sql, sql);
assert.strictEqual(layers[0].options.cartocss, cartocss);
assert.strictEqual(layers[0].options.cartocss_version, cartocss_version);
assert.strictEqual(layers[0].options.overviews, undefined);
done();
});
});
@@ -79,11 +79,11 @@ describe('MapConfigOverviewsAdapter', function () {
mapConfigOverviewsAdapter.getMapConfig('localhost', _mapConfig, params, context, function (err, mapConfig) {
assert.ok(!err);
var layers = mapConfig.layers;
assert.equal(layers.length, 1);
assert.equal(layers[0].type, 'cartodb');
assert.equal(layers[0].options.sql, sql);
assert.equal(layers[0].options.cartocss, cartocss);
assert.equal(layers[0].options.cartocss_version, cartocss_version);
assert.strictEqual(layers.length, 1);
assert.strictEqual(layers[0].type, 'cartodb');
assert.strictEqual(layers[0].options.sql, sql);
assert.strictEqual(layers[0].options.cartocss, cartocss);
assert.strictEqual(layers[0].options.cartocss_version, cartocss_version);
assert.ok(layers[0].options.query_rewrite_data);
var expected_data = {
overviews: {
+2 -2
View File
@@ -26,7 +26,7 @@ describe('PgQueryRunner', function () {
assert.ok(!err, err);
assert.ok(Array.isArray(result));
assert.equal(result.length, 3);
assert.strictEqual(result.length, 3);
done();
});
@@ -38,7 +38,7 @@ describe('PgQueryRunner', function () {
assert.ok(err);
assert.ok(Array.isArray(result));
assert.equal(result.length, 0);
assert.strictEqual(result.length, 0);
done();
});
+1 -1
View File
@@ -40,7 +40,7 @@ describe('profiler + statsd', function () {
// force a call to validate sendStats does not throw and uncaught exception
statsClient.timing('forced', 50, 1, function (err) {
assert.ok(err);
assert.equal(err.code, 'ENOTFOUND');
assert.strictEqual(err.code, 'ENOTFOUND');
done();
});
});
+10 -10
View File
@@ -34,12 +34,12 @@ describe('QueryTables', function () {
var query = 'select * from test_table';
return QueryTables.getQueryMetadataModel(connection, query)
.then(result => {
assert.equal(result.getLastUpdatedAt(), 1234567890123);
assert.strictEqual(result.getLastUpdatedAt(), 1234567890123);
assert.equal(result.tables.length, 1);
assert.equal(result.tables[0].dbname, 'test_windshaft_cartodb_user_1_db');
assert.equal(result.tables[0].schema_name, 'public');
assert.equal(result.tables[0].table_name, 'test_table');
assert.strictEqual(result.tables.length, 1);
assert.strictEqual(result.tables[0].dbname, 'test_windshaft_cartodb_user_1_db');
assert.strictEqual(result.tables[0].schema_name, 'public');
assert.strictEqual(result.tables[0].table_name, 'test_table');
});
});
@@ -47,12 +47,12 @@ describe('QueryTables', function () {
var query = 'select * from test_table_private_1';
return QueryTables.getQueryMetadataModel(connection, query)
.then(result => {
assert.equal(result.getLastUpdatedAt(), 1234567890123);
assert.strictEqual(result.getLastUpdatedAt(), 1234567890123);
assert.equal(result.tables.length, 1);
assert.equal(result.tables[0].dbname, 'test_windshaft_cartodb_user_1_db');
assert.equal(result.tables[0].schema_name, 'public');
assert.equal(result.tables[0].table_name, 'test_table_private_1');
assert.strictEqual(result.tables.length, 1);
assert.strictEqual(result.tables[0].dbname, 'test_windshaft_cartodb_user_1_db');
assert.strictEqual(result.tables[0].schema_name, 'public');
assert.strictEqual(result.tables[0].table_name, 'test_table_private_1');
});
});
});
@@ -70,7 +70,7 @@ describe('TemplateMaps limits', function () {
assert.ok(template);
templateMaps.addTemplate(OWNER, createTemplate(), function (err) {
assert.ok(err);
assert.equal(err.http_status, 409);
assert.strictEqual(err.http_status, 409);
done();
});
});