diff --git a/lib/cartodb/controllers/map/anonymous.js b/lib/cartodb/controllers/map/anonymous.js index d90820c4..02c6807e 100644 --- a/lib/cartodb/controllers/map/anonymous.js +++ b/lib/cartodb/controllers/map/anonymous.js @@ -10,6 +10,7 @@ const dbConnSetup = require('../../middleware/db-conn-setup'); const authorize = require('../../middleware/authorize'); const initProfiler = require('./middlewares/init-profiler'); const checkJsonContentType = require('./middlewares/check-json-content-type'); +const incrementMapViewCount = require('./middlewares/increment-map-view-count'); const cacheControlHeader = require('../../middleware/cache-control-header'); const cacheChannelHeader = require('../../middleware/cache-channel-header'); const surrogateKeyHeader = require('../../middleware/surrogate-key-header'); @@ -215,23 +216,6 @@ function createLayergroup (mapBackend, userLimitsApi, pgConnection, affectedTabl }; } -function incrementMapViewCount (metadataBackend) { - return function incrementMapViewCountMiddleware(req, res, next) { - const { mapConfig, user } = res.locals; - - // Error won't blow up, just be logged. - metadataBackend.incMapviewCount(user, mapConfig.obj().stat_tag, (err) => { - req.profiler.done('incMapviewCount'); - - if (err) { - global.logger.log(`ERROR: failed to increment mapview count for user '${user}': ${err.message}`); - } - - next(); - }); - }; -} - function augmentLayergroupData () { return function augmentLayergroupDataMiddleware (req, res, next) { const layergroup = res.body; diff --git a/lib/cartodb/controllers/map/middlewares/increment-map-view-count.js b/lib/cartodb/controllers/map/middlewares/increment-map-view-count.js new file mode 100644 index 00000000..acf241fd --- /dev/null +++ b/lib/cartodb/controllers/map/middlewares/increment-map-view-count.js @@ -0,0 +1,16 @@ +module.exports = function incrementMapViewCount (metadataBackend) { + return function incrementMapViewCountMiddleware(req, res, next) { + const { mapConfig, user } = res.locals; + + // Error won't blow up, just be logged. + metadataBackend.incMapviewCount(user, mapConfig.obj().stat_tag, (err) => { + req.profiler.done('incMapviewCount'); + + if (err) { + global.logger.log(`ERROR: failed to increment mapview count for user '${user}': ${err.message}`); + } + + next(); + }); + }; +}; diff --git a/lib/cartodb/controllers/map/named.js b/lib/cartodb/controllers/map/named.js index 73822421..f880587c 100644 --- a/lib/cartodb/controllers/map/named.js +++ b/lib/cartodb/controllers/map/named.js @@ -6,6 +6,7 @@ const dbConnSetup = require('../../middleware/db-conn-setup'); const authorize = require('../../middleware/authorize'); const initProfiler = require('./middlewares/init-profiler'); const checkJsonContentType = require('./middlewares/check-json-content-type'); +const incrementMapViewCount = require('./middlewares/increment-map-view-count'); const cacheControlHeader = require('../../middleware/cache-control-header'); const cacheChannelHeader = require('../../middleware/cache-channel-header'); const surrogateKeyHeader = require('../../middleware/surrogate-key-header'); @@ -221,23 +222,6 @@ function instantiateLayergroup (mapBackend, userLimitsApi, pgConnection, affecte }; } -function incrementMapViewCount (metadataBackend) { - return function incrementMapViewCountMiddleware(req, res, next) { - const { mapConfig, user } = res.locals; - - // Error won't blow up, just be logged. - metadataBackend.incMapviewCount(user, mapConfig.obj().stat_tag, (err) => { - req.profiler.done('incMapviewCount'); - - if (err) { - global.logger.log(`ERROR: failed to increment mapview count for user '${user}': ${err.message}`); - } - - next(); - }); - }; -} - function augmentLayergroupData () { return function augmentLayergroupDataMiddleware (req, res, next) { const layergroup = res.body;