From 22086ba9141e84f22ab5e0be9dea7cdd90b0d23c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Garc=C3=ADa=20Aubert?= Date: Fri, 19 Jun 2020 10:18:06 +0200 Subject: [PATCH] Count requests even when the info is not complete --- metro/metrics-collector.js | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/metro/metrics-collector.js b/metro/metrics-collector.js index 8343ebb6..e20377e8 100644 --- a/metro/metrics-collector.js +++ b/metro/metrics-collector.js @@ -79,20 +79,22 @@ module.exports = function metricsCollector () { const { statusCode, headers } = response; const { 'carto-user': user } = headers; - if (statusCode === undefined || headers === undefined || user === undefined) { - this.push(chunk); - return callback(); - } - requestCounter.inc(); - userRequestCounter.labels(user, `${statusCode}`).inc(); + + if (statusCode !== undefined && user !== undefined) { + userRequestCounter.labels(user, `${statusCode}`).inc(); + } if (statusCode >= 200 && statusCode < 400) { requestOkCounter.inc(); - userRequestOkCounter.labels(user, `${statusCode}`).inc(); - } else { + if (user !== undefined) { + userRequestOkCounter.labels(user, `${statusCode}`).inc(); + } + } else if (statusCode >= 400) { requestErrorCounter.inc(); - userRequestErrorCounter.labels(user, `${statusCode}`).inc(); + if (user !== undefined) { + userRequestErrorCounter.labels(user, `${statusCode}`).inc(); + } } const { response: responseTime } = stats;