From 2650c3b3e6a67aeee7a38b16b161780997136a1e Mon Sep 17 00:00:00 2001 From: Simon Date: Fri, 8 Sep 2017 17:51:02 +0200 Subject: [PATCH] removing self=this assignment --- lib/cartodb/models/dataview/date-histogram.js | 10 ++++------ lib/cartodb/models/dataview/numeric-histogram.js | 10 ++++------ 2 files changed, 8 insertions(+), 12 deletions(-) diff --git a/lib/cartodb/models/dataview/date-histogram.js b/lib/cartodb/models/dataview/date-histogram.js index 0e11befe..8315cd81 100644 --- a/lib/cartodb/models/dataview/date-histogram.js +++ b/lib/cartodb/models/dataview/date-histogram.js @@ -186,23 +186,21 @@ module.exports = class DateHistogram extends BaseDataview { } sql (psql, override, callback) { - let self = this; - if (!callback) { callback = override; override = {}; } if (this._columnType === null) { - this.getColumnType(psql, this.column, this.queries.no_filters, function (err, type) { + this.getColumnType(psql, this.column, this.queries.no_filters, (err, type) => { // assume numeric, will fail later - self._columnType = 'numeric'; + this._columnType = 'numeric'; if (!err && !!type) { - self._columnType = Object.keys(type).find(function (key) { + this._columnType = Object.keys(type).find(function (key) { return type[key]; }); } - self.sql(psql, override, callback); + this.sql(psql, override, callback); }, true); // use read-only transaction return null; } diff --git a/lib/cartodb/models/dataview/numeric-histogram.js b/lib/cartodb/models/dataview/numeric-histogram.js index 891de107..4968bd58 100644 --- a/lib/cartodb/models/dataview/numeric-histogram.js +++ b/lib/cartodb/models/dataview/numeric-histogram.js @@ -178,23 +178,21 @@ module.exports = class NumericHistogram extends BaseDataview { } sql (psql, override, callback) { - let self = this; - if (!callback) { callback = override; override = {}; } if (this._columnType === null) { - this.getColumnType(psql, this.column, this.queries.no_filters, function (err, type) { + this.getColumnType(psql, this.column, this.queries.no_filters, (err, type) => { // assume numeric, will fail later - self._columnType = 'numeric'; + this._columnType = 'numeric'; if (!err && !!type) { - self._columnType = Object.keys(type).find(function (key) { + this._columnType = Object.keys(type).find(function (key) { return type[key]; }); } - self.sql(psql, override, callback); + this.sql(psql, override, callback); }, true); // use read-only transaction return null; }