From e43ccf4f1274ec4dd384cdfac77f647e7dfb78d3 Mon Sep 17 00:00:00 2001 From: Raul Ochoa Date: Thu, 28 Dec 2017 18:19:52 +0000 Subject: [PATCH 1/2] Going red: individual layer id filters fail Depends on https://github.com/CartoDB/Windshaft/pull/584. --- test/acceptance/layers-filters.js | 54 +++++++++++++++++++++++++++++++ 1 file changed, 54 insertions(+) create mode 100644 test/acceptance/layers-filters.js diff --git a/test/acceptance/layers-filters.js b/test/acceptance/layers-filters.js new file mode 100644 index 00000000..fa42c900 --- /dev/null +++ b/test/acceptance/layers-filters.js @@ -0,0 +1,54 @@ +require('../support/test_helper'); +var TestClient = require('../support/test-client'); + +describe('layers filters', function() { + const type = 'mapnik'; + const sql = 'select * from populated_places_simple_reduced'; + const cartocss = `#points { + marker-fill-opacity: 1.0; + marker-line-color: #FFF; + marker-line-width: 0.5; + marker-line-opacity: 1.0; + marker-placement: point; + marker-type: ellipse; + marker-width: 8; + marker-fill: red; + marker-allow-overlap: true; + }`; + const cartocss_version = '3.0.12'; + const options = { + sql, + cartocss, + cartocss_version + }; + + const mapConfig = { + version: '1.6.0', + layers: [ + { + type, + id: 'layerA', + options + }, + { + type, + id: 'layerB', + options + } + ] + }; + + afterEach(function(done) { + if (this.testClient) { + this.testClient.drain(done); + } + }); + + ['layerA', 'layerB'].forEach(layer => { + it(`should work for individual layer ids: ${layer}`, function (done) { + this.testClient = new TestClient(mapConfig); + this.testClient.getTile(0, 0, 0, { layers: layer }, done); + }); + }); + +}); \ No newline at end of file From a75beefe6e95f54aa9096946a2609dba03591346 Mon Sep 17 00:00:00 2001 From: Raul Ochoa Date: Thu, 28 Dec 2017 18:34:53 +0000 Subject: [PATCH 2/2] Upgrades windshaft to 4.1.1 --- NEWS.md | 1 + package.json | 2 +- yarn.lock | 16 ++++++++-------- 3 files changed, 10 insertions(+), 9 deletions(-) diff --git a/NEWS.md b/NEWS.md index 968646b7..24a86655 100644 --- a/NEWS.md +++ b/NEWS.md @@ -4,6 +4,7 @@ Released YYYY-MM-DD Announcements: + - Upgrades windshaft to [4.1.1](https://github.com/CartoDB/windshaft/releases/tag/4.1.1). - Validate aggregation input params - Fix column names collisions in histograms [#828](https://github.com/CartoDB/Windshaft-cartodb/pull/828) diff --git a/package.json b/package.json index dd210fc0..f7386669 100644 --- a/package.json +++ b/package.json @@ -46,7 +46,7 @@ "step-profiler": "~0.3.0", "turbo-carto": "0.20.2", "underscore": "~1.6.0", - "windshaft": "4.1.0", + "windshaft": "4.1.1", "yargs": "~5.0.0" }, "devDependencies": { diff --git a/yarn.lock b/yarn.lock index 78e663f0..26e59383 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2,7 +2,7 @@ # yarn lockfile v1 -abaculus@cartodb/abaculus#2.0.3-cdb1: +"abaculus@github:cartodb/abaculus#2.0.3-cdb1": version "2.0.3-cdb1" resolved "https://codeload.github.com/cartodb/abaculus/tar.gz/f5f34e1c80cdd8d49edd1d6fe3b2220ab2e23aaf" dependencies: @@ -226,7 +226,7 @@ camshaft@0.60.0: dot "^1.0.3" request "^2.69.0" -canvas@cartodb/node-canvas#1.6.2-cdb2: +"canvas@github:cartodb/node-canvas#1.6.2-cdb2": version "1.6.2-cdb2" resolved "https://codeload.github.com/cartodb/node-canvas/tar.gz/8acf04557005c633f9e68524488a2657c04f3766" dependencies: @@ -252,7 +252,7 @@ carto@CartoDB/carto#0.15.1-cdb1: optimist "~0.6.0" underscore "~1.6.0" -carto@cartodb/carto#0.15.1-cdb3: +"carto@github:cartodb/carto#0.15.1-cdb3": version "0.15.1-cdb3" resolved "https://codeload.github.com/cartodb/carto/tar.gz/945f5efb74fd1af1f5e1f69f409f9567f94fb5a7" dependencies: @@ -2223,7 +2223,7 @@ through@2: version "2.3.8" resolved "https://registry.yarnpkg.com/through/-/through-2.3.8.tgz#0dd4c9ffaabc357960b1b724115d7e0e86a2e1f5" -tilelive-bridge@cartodb/tilelive-bridge#2.3.1-cdb4: +"tilelive-bridge@github:cartodb/tilelive-bridge#2.3.1-cdb4": version "2.3.1-cdb4" resolved "https://codeload.github.com/cartodb/tilelive-bridge/tar.gz/faa2b638da2d119b78281575d40255cb523f6ca6" dependencies: @@ -2231,7 +2231,7 @@ tilelive-bridge@cartodb/tilelive-bridge#2.3.1-cdb4: mapnik-pool "~0.1.3" sphericalmercator "1.0.x" -tilelive-mapnik@cartodb/tilelive-mapnik#0.6.18-cdb3: +"tilelive-mapnik@github:cartodb/tilelive-mapnik#0.6.18-cdb3": version "0.6.18-cdb3" resolved "https://codeload.github.com/cartodb/tilelive-mapnik/tar.gz/23bd1c31dd57d0b76c86b9f1eaf62462b3c17d01" dependencies: @@ -2392,9 +2392,9 @@ window-size@^0.2.0: version "0.2.0" resolved "https://registry.yarnpkg.com/window-size/-/window-size-0.2.0.tgz#b4315bb4214a3d7058ebeee892e13fa24d98b075" -windshaft@4.1.0: - version "4.1.0" - resolved "https://registry.yarnpkg.com/windshaft/-/windshaft-4.1.0.tgz#dc17c8369570c305171d1ab5ca130369bba04d58" +windshaft@4.1.1: + version "4.1.1" + resolved "https://registry.yarnpkg.com/windshaft/-/windshaft-4.1.1.tgz#cdae06202e841b8e75915de5155b8a279b4547be" dependencies: abaculus cartodb/abaculus#2.0.3-cdb1 canvas cartodb/node-canvas#1.6.2-cdb2