From 8a1d5d3a489cc26e94a4c181f99c64f33adea303 Mon Sep 17 00:00:00 2001 From: Javier Goizueta Date: Mon, 28 May 2018 17:36:58 +0200 Subject: [PATCH] Be careful and detect type invalid types --- lib/cartodb/utils/query-utils.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/cartodb/utils/query-utils.js b/lib/cartodb/utils/query-utils.js index ae1a2e2d..867db0cd 100644 --- a/lib/cartodb/utils/query-utils.js +++ b/lib/cartodb/utils/query-utils.js @@ -92,10 +92,13 @@ function columnSelector(columns) { if (!columns) { return '*'; } - if (typeof(columns) === 'string') { + if (typeof columns === 'string') { return columns; } - return columns.map(name => `"${name}"`).join(', '); + if (Array.isArray(columns)) { + return columns.map(name => `"${name}"`).join(', '); + } + throw new TypeError(`Bad argument type for columns: ${typeof columns}`); } module.exports.getQuerySample = function(query, sampleProb, limit = null, randomSeed = 0.5, columns = null) {