From ac49abe7504bbaf197e18b1f3be29e583e649882 Mon Sep 17 00:00:00 2001 From: Sandro Santilli Date: Mon, 28 Jan 2013 17:13:49 +0100 Subject: [PATCH] Do not leak redis client connections on redis command error --- lib/cartodb/carto_data.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/cartodb/carto_data.js b/lib/cartodb/carto_data.js index 5ad4723c..83b9933b 100644 --- a/lib/cartodb/carto_data.js +++ b/lib/cartodb/carto_data.js @@ -232,8 +232,7 @@ module.exports = function() { redisClient[redisFunc.toUpperCase()].apply(redisClient, redisArgs); }, function releaseRedisClient(err, data) { - if (err) throw err; - redis_pool.release(db, redisClient); + if ( ! _.isUndefined(redisClient) ) redis_pool.release(db, redisClient); callback(err, data); } );