From afd4c3b46044719d0e830e0a6e212133d5fdddbd Mon Sep 17 00:00:00 2001 From: Sandro Santilli Date: Mon, 15 Jul 2013 12:02:54 +0200 Subject: [PATCH] Set Last-Modified header to allow for 304 responses --- NEWS.md | 1 + lib/cartodb/server_options.js | 9 ++++++++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/NEWS.md b/NEWS.md index de8d214c..087b9173 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,5 +1,6 @@ 1.3.3 ------ +* Set Last-Modified header to allow for 304 responses 1.3.2 ------ diff --git a/lib/cartodb/server_options.js b/lib/cartodb/server_options.js index 177d6aab..86c607f3 100644 --- a/lib/cartodb/server_options.js +++ b/lib/cartodb/server_options.js @@ -215,10 +215,17 @@ module.exports = function(){ res.header('Cache-Control', 'public,max-age=31536000'); // 1 year } else { var ttl = global.environment.varnish.ttl || 86400; - res.header('Last-Modified', new Date().toUTCString()); res.header('Cache-Control', 'no-cache,max-age='+ttl+',must-revalidate, public'); } + // Set Last-Modified header + // + // Currently sets it to NOW + // + // TODO: find out a real value, querying for most recent change in + // any of the source tables + res.header('Last-Modified', new Date().toUTCString()); + me.generateCacheChannel(req, function(err, channel){ if ( ! err ) { res.header('X-Cache-Channel', channel);