From b82767c60d6bd4f082a75969a99533ea141878ed Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Garc=C3=ADa=20Aubert?= Date: Mon, 15 Jan 2018 17:08:54 +0100 Subject: [PATCH] Pass a copy of res.locals w/o new data boud to named-map-provider-cache --- lib/cartodb/controllers/named_maps.js | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/lib/cartodb/controllers/named_maps.js b/lib/cartodb/controllers/named_maps.js index f668d638..9f848495 100644 --- a/lib/cartodb/controllers/named_maps.js +++ b/lib/cartodb/controllers/named_maps.js @@ -74,8 +74,9 @@ NamedMapsController.prototype.getNamedMapProvider = function (label) { const { user } = res.locals; const { config, auth_token } = req.query; const { template_id } = req.params; + const params = Object.assign({}, res.locals); - this.namedMapProviderCache.get(user, template_id, config, auth_token, res.locals, (err, namedMapProvider) => { + this.namedMapProviderCache.get(user, template_id, config, auth_token, params, (err, namedMapProvider) => { if (err) { err.label = label; return next(err); @@ -146,11 +147,17 @@ NamedMapsController.prototype.prepareLayerFilterFromPreviewLayers = function (la return next(); } + const params = Object.assign({}, res.locals); + + delete params.template; + delete params.affectedTablesAndLastUpdate; + delete params.namedMapProvider; + // overwrites 'all' default filter - res.locals.layer = layerVisibilityFilter.join(','); + params.layer = layerVisibilityFilter.join(','); // recreates the provider - this.namedMapProviderCache.get(user, template_id, config, auth_token, res.locals, (err, provider) => { + this.namedMapProviderCache.get(user, template_id, config, auth_token, params, (err, provider) => { if (err) { err.label = label; return next(err);