Logger: rename 'error' => 'exception' to avoid name clashing in E/S

lib/api/api-router.js

@@ -236,7 +236,7 @@ function createTemplateMaps ({ redisPool, surrogateKeysCache, logger }) {
         const startTime = Date.now();
         surrogateKeysCache.invalidate(new NamedMapsCacheEntry(user, templateName), (err) => {
             if (err) {
-                return logger.error({ error: err, 'cdb-user': user, template_id: templateName }, 'Named map invalidation failed');
+                return logger.error({ exception: err, 'cdb-user': user, template_id: templateName }, 'Named map invalidation failed');
             }
 
             logger.info({ 'cdb-user': user, template_id: templateName, duration: (Date.now() - startTime) / 1000 }, 'Named map invalidation success');

lib/api/map/preview-template-controller.js

@@ -343,7 +343,7 @@ function incrementMapViews ({ metadataBackend }) {
 
         mapConfigProvider.getMapConfig((err, mapConfig) => {
             if (err) {
-                logger.warn({ error: err }, 'Failed to increment mapview count');
+                logger.warn({ exception: err }, 'Failed to increment mapview count');
                 return next();
             }
 
@@ -353,7 +353,7 @@ function incrementMapViews ({ metadataBackend }) {
 
             metadataBackend.incMapviewCount(user, statTag, (err) => {
                 if (err) {
-                    logger.warn({ error: err }, 'Failed to increment mapview count');
+                    logger.warn({ exception: err }, 'Failed to increment mapview count');
                 }
 
                 next();

lib/api/middlewares/cache-channel-header.js

@@ -10,7 +10,7 @@ module.exports = function setCacheChannelHeader () {
 
         mapConfigProvider.getAffectedTables((err, affectedTables) => {
             if (err) {
-                logger.warn({ error: err }, 'Error generating Cache Channel Header');
+                logger.warn({ exception: err }, 'Error generating Cache Channel Header');
                 return next();
             }
 

lib/api/middlewares/cache-control-header.js

@@ -44,7 +44,7 @@ module.exports = function setCacheControlHeader ({
 
         mapConfigProvider.getAffectedTables((err, affectedTables) => {
             if (err) {
-                logger.warn({ error: err }, 'Error generating Cache Control Header');
+                logger.warn({ exception: err }, 'Error generating Cache Control Header');
                 return next();
             }
 

lib/api/middlewares/error-middleware.js

@@ -7,7 +7,7 @@ module.exports = function errorMiddleware (/* options */) {
         const { logger } = res.locals;
         const errors = populateLimitErrors(Array.isArray(err) ? err : [err]);
 
-        errors.forEach((err) => logger.error({ error: err }, 'Error while handling the request'));
+        errors.forEach((err) => logger.error({ exception: err }, 'Error while handling the request'));
 
         setCommonHeaders(req, res, () => {
             const errorResponseBody = {

lib/api/middlewares/increment-map-view-count.js

@@ -7,7 +7,7 @@ module.exports = function incrementMapViewCount (metadataBackend) {
 
         metadataBackend.incMapviewCount(user, statTag, (err) => {
             if (err) {
-                logger.warn({ error: err }, 'Failed to increment mapview count');
+                logger.warn({ exception: err }, 'Failed to increment mapview count');
             }
 
             next();

lib/api/middlewares/last-modified-header.js

@@ -21,7 +21,7 @@ module.exports = function setLastModifiedHeader () {
 
         mapConfigProvider.getAffectedTables((err, affectedTables) => {
             if (err) {
-                logger.warn({ error: err }, 'Error generating Last Modified Header');
+                logger.warn({ exception: err }, 'Error generating Last Modified Header');
                 return next();
             }
 

lib/api/middlewares/metrics.js

@@ -23,7 +23,7 @@ module.exports = function metrics ({ enabled, tags, metricsBackend }) {
             const { event, attributes } = getEventData(req, res, tags);
 
             metricsBackend.send(event, attributes)
-                .catch((err) => logger.error({ error: err, event }, 'Failed to publish event'));
+                .catch((err) => logger.error({ exception: err, event }, 'Failed to publish event'));
         });
 
         return next();

lib/api/middlewares/surrogate-key-header.js

@@ -17,7 +17,7 @@ module.exports = function setSurrogateKeyHeader ({ surrogateKeysCache }) {
 
         mapConfigProvider.getAffectedTables((err, affectedTables) => {
             if (err) {
-                logger.warn({ error: err }, 'Error generating Surrogate Key Header');
+                logger.warn({ exception: err }, 'Error generating Surrogate Key Header');
                 return next();
             }