diff --git a/lib/cartodb/controllers/named_maps.js b/lib/cartodb/controllers/named_maps.js index 6e897c35..b16f1f69 100644 --- a/lib/cartodb/controllers/named_maps.js +++ b/lib/cartodb/controllers/named_maps.js @@ -10,8 +10,8 @@ var cors = require('../middleware/cors'); var TablesCacheEntry = require('../cache/model/database_tables_entry'); -function NamedMapsController(app, authApi, pgConnection, namedMapProviderCache, tileBackend, previewBackend, surrogateKeysCache, - tablesExtentApi) { +function NamedMapsController(app, authApi, pgConnection, namedMapProviderCache, tileBackend, previewBackend, + surrogateKeysCache, tablesExtentApi) { BaseController.call(this, authApi, pgConnection); this.app = app; diff --git a/lib/cartodb/controllers/named_maps_admin.js b/lib/cartodb/controllers/named_maps_admin.js index c57e3c9f..02792cf3 100644 --- a/lib/cartodb/controllers/named_maps_admin.js +++ b/lib/cartodb/controllers/named_maps_admin.js @@ -21,6 +21,8 @@ function NamedMapsAdminController(templateMaps, authApi, pgConnection) { this.authApi = authApi; } +util.inherits(NamedMapsAdminController, BaseController); + module.exports = NamedMapsAdminController; NamedMapsAdminController.prototype.register = function(app) { diff --git a/test/acceptance/ported/attributes.js b/test/acceptance/ported/attributes.js index 6c9f9c1c..da6bfcba 100644 --- a/test/acceptance/ported/attributes.js +++ b/test/acceptance/ported/attributes.js @@ -5,11 +5,12 @@ var redis = require('redis'); var step = require('step'); var cartodbServer = require('../../../lib/cartodb/server'); var PortedServerOptions = require('./support/ported_server_options'); +var BaseController = require('../../../lib/cartodb/controllers/base'); + describe('attributes', function() { var server = cartodbServer(PortedServerOptions); - server.req2params = PortedServerOptions.req2params; server.setMaxListeners(0); var redis_client = redis.createClient(PortedServerOptions.redis.port); @@ -38,6 +39,16 @@ describe('attributes', function() { assert.equal(res.headers['access-control-allow-origin'], '*'); } + var req2paramsFn; + before(function() { + req2paramsFn = BaseController.prototype.req2params; + BaseController.prototype.req2params = PortedServerOptions.req2params; + }); + + after(function() { + BaseController.prototype.req2params = req2paramsFn; + }); + it("can only be fetched from layer having an attributes spec", function(done) { var expected_token; diff --git a/test/acceptance/ported/blend.js b/test/acceptance/ported/blend.js index 11f971bb..eca436ae 100644 --- a/test/acceptance/ported/blend.js +++ b/test/acceptance/ported/blend.js @@ -3,8 +3,21 @@ require('../../support/test_helper'); var assert = require('../../support/assert'); var testClient = require('./support/test_client'); +var PortedServerOptions = require('./support/ported_server_options'); +var BaseController = require('../../../lib/cartodb/controllers/base'); + describe('blend png renderer', function() { + var req2paramsFn; + before(function() { + req2paramsFn = BaseController.prototype.req2params; + BaseController.prototype.req2params = PortedServerOptions.req2params; + }); + + after(function() { + BaseController.prototype.req2params = req2paramsFn; + }); + var IMAGE_TOLERANCE_PER_MIL = 20; function plainTorqueMapConfig(plainColor) { diff --git a/test/acceptance/ported/blend_filtering.js b/test/acceptance/ported/blend_filtering.js index 46e35699..c1b11933 100644 --- a/test/acceptance/ported/blend_filtering.js +++ b/test/acceptance/ported/blend_filtering.js @@ -5,13 +5,20 @@ var testClient = require('./support/test_client'); var fs = require('fs'); var http = require('http'); +var PortedServerOptions = require('./support/ported_server_options'); +var BaseController = require('../../../lib/cartodb/controllers/base'); + describe('blend layer filtering', function() { var IMG_TOLERANCE_PER_MIL = 20; var httpRendererResourcesServer; + var req2paramsFn; before(function(done) { + req2paramsFn = BaseController.prototype.req2params; + BaseController.prototype.req2params = PortedServerOptions.req2params; + // Start a server to test external resources httpRendererResourcesServer = http.createServer( function(request, response) { var filename = __dirname + '/../../fixtures/http/light_nolabels-1-0-0.png'; @@ -25,6 +32,7 @@ describe('blend layer filtering', function() { }); after(function(done) { + BaseController.prototype.req2params = req2paramsFn; httpRendererResourcesServer.close(done); }); diff --git a/test/acceptance/ported/blend_http_fallback.js b/test/acceptance/ported/blend_http_fallback.js index 60fd5555..7d0d89c2 100644 --- a/test/acceptance/ported/blend_http_fallback.js +++ b/test/acceptance/ported/blend_http_fallback.js @@ -5,13 +5,19 @@ var testClient = require('./support/test_client'); var fs = require('fs'); var http = require('http'); +var PortedServerOptions = require('./support/ported_server_options'); +var BaseController = require('../../../lib/cartodb/controllers/base'); + describe('blend http fallback', function() { var IMG_TOLERANCE_PER_MIL = 20; var httpRendererResourcesServer; + var req2paramsFn; before(function(done) { + req2paramsFn = BaseController.prototype.req2params; + BaseController.prototype.req2params = PortedServerOptions.req2params; // Start a server to test external resources httpRendererResourcesServer = http.createServer( function(request, response) { if (request.url.match(/^\/error404\//)) { @@ -33,6 +39,7 @@ describe('blend http fallback', function() { }); after(function(done) { + BaseController.prototype.req2params = req2paramsFn; httpRendererResourcesServer.close(done); }); diff --git a/test/acceptance/ported/blend_http_timeout.js b/test/acceptance/ported/blend_http_timeout.js index 53c917e3..341f72b3 100644 --- a/test/acceptance/ported/blend_http_timeout.js +++ b/test/acceptance/ported/blend_http_timeout.js @@ -6,8 +6,21 @@ var serverOptions = require('./support/ported_server_options'); var fs = require('fs'); var http = require('http'); +var PortedServerOptions = require('./support/ported_server_options'); +var BaseController = require('../../../lib/cartodb/controllers/base'); + describe.skip('blend http client timeout', function() { + var req2paramsFn; + before(function() { + req2paramsFn = BaseController.prototype.req2params; + BaseController.prototype.req2params = PortedServerOptions.req2params; + }); + + after(function() { + BaseController.prototype.req2params = req2paramsFn; + }); + var mapConfig = { version: '1.3.0', layers: [ diff --git a/test/acceptance/ported/external_resources.js b/test/acceptance/ported/external_resources.js index 378d7f2d..0b365ef8 100644 --- a/test/acceptance/ported/external_resources.js +++ b/test/acceptance/ported/external_resources.js @@ -7,6 +7,8 @@ var PortedServerOptions = require('./support/ported_server_options'); var http = require('http'); var testClient = require('./support/test_client'); +var BaseController = require('../../../lib/cartodb/controllers/base'); + function rmdir_recursive_sync(dirname) { var files = fs.readdirSync(dirname); for (var i=0; i