From ecbae52abe0d9ea9701ee5f914489a8e2be6dda5 Mon Sep 17 00:00:00 2001 From: Javier Goizueta Date: Wed, 20 Apr 2016 17:24:16 +0200 Subject: [PATCH] Refactor: use reduce for collecting overviews metadata --- lib/cartodb/api/overviews_metadata_api.js | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/lib/cartodb/api/overviews_metadata_api.js b/lib/cartodb/api/overviews_metadata_api.js index 4e6109c1..81ab1a1c 100644 --- a/lib/cartodb/api/overviews_metadata_api.js +++ b/lib/cartodb/api/overviews_metadata_api.js @@ -31,18 +31,17 @@ OverviewsMetadataApi.prototype.getOverviewsMetadata = function (username, sql, c callback(err); return; } - var metadata = {}; - rows.forEach(function(row) { + var metadata = rows.reduce(function(metadata, row){ var table = row.base_table; var schema = row._cdb_schema_name; var table_metadata = metadata[table]; if ( !table_metadata ) { - table_metadata = metadata[table] = {}; + table_metadata = metadata[table] = {}; } table_metadata[row.z] = { table: row.overview_table }; table_metadata.schema = schema; - }); + return metadata; + }, {}); return callback(null, metadata); }); - };