Commit Graph
2015 Commits
Author SHA1 Message Date
Daniel García Aubert 5cfffcfa83 Use const instead of var 2018-05-30 17:22:12 +02:00
Daniel García Aubert 4e28f7bb4e Do not require assert and step 2018-05-30 17:10:18 +02:00
Daniel García Aubert 532d50ad7a Return 'null' explicitly 2018-05-30 17:09:01 +02:00
Daniel García Aubert d8b0d338c0 Use 'const' instead of 'var' 2018-05-30 17:02:15 +02:00
Daniel García Aubert cd0be5f79d Do not require 'step' 2018-05-30 17:00:55 +02:00
Daniel García Aubert 3820894454 Do not use 'step' 2018-05-30 17:00:15 +02:00
Daniel García Aubert fe79ee0315 Merge branch 'master' into unify-connection-pool-config 2018-05-29 16:44:21 +02:00
Javier Goizueta 26da872704 Leave sample exclude_columns for later 2018-05-28 17:37:45 +02:00
Javier Goizueta 8a1d5d3a48 Be careful and detect type invalid types 2018-05-28 17:36:58 +02:00
Javier Goizueta 4bb8914d9a Add parameters to select metadata sample columns 2018-05-28 16:08:31 +02:00
Daniel García Aubert bbab9c1a6b Avoid breaking changes 2018-05-25 14:44:58 +02:00
Daniel García Aubert 8fe192267d cosmetic 2018-05-25 13:37:57 +02:00
Daniel García Aubert 92255797d9 Add torque options to renderer factory 2018-05-25 13:37:34 +02:00
Daniel García Aubert f404285140 Use postgres pool configuration to have the same configuration for all renderers. 2018-05-24 18:36:45 +02:00
Daniel García Aubert ee38c717a5 Remove geojson renderer config 2018-05-24 18:11:18 +02:00
Daniel García Aubert 1668392296 Move 'postgres' attributes inside Mapnik's renderer configuration and keep params relative to user's connection 2018-05-24 13:42:32 +02:00
Javier Goizueta c1feaecbcb Merge branch 'master' into refactor-metadata
# Conflicts:
#	lib/cartodb/backends/layer-stats/mapnik-layer-stats.js
2018-05-23 12:12:36 +02:00
Javier Goizueta 94c34eeb23 Small change to use const 2018-05-23 11:15:20 +02:00
Javier Goizueta 97b4e19777 Add metadata parameter for NULL categories 2018-05-22 13:00:18 +02:00
Javier Goizueta ebc086106f Refactor metadata queryPromise helper
This function to adapt query execution as a Promise was unnecessary complex.
2018-05-21 17:33:03 +02:00
Javier Goizueta 6384f5538c Rename variable for clarity 2018-05-21 17:06:53 +02:00
Javier Goizueta d7a90e6be4 Remove debugging comment 2018-05-21 15:54:52 +02:00
Javier Goizueta b233f18a0f Modernize code copied from SQL API 2018-05-21 15:43:23 +02:00
Javier Goizueta 32092d212e Fix bug 2018-05-21 14:05:27 +02:00
Javier Goizueta 11cdcc65ad Add safety limit to sample metadata
The sampling probability is now being computed using an estimate of the table row count
This could led to too high probabilities (to large samples) if the estimate is not accurate.
To avoid potential problems with large samples we've added a LIMIT to the sampling queries.
2018-05-21 12:45:16 +02:00
Javier Goizueta fecd63e582 Fix bug 2018-05-21 11:59:49 +02:00
Javier Goizueta 38e55367b1 Revert error behaviour for estimatedFeatureCount
Keep current production behavior of ignoreing errors when computing this stat and returning -1.
This is done as to no introduce any instability in production at the moment.
2018-05-21 11:44:52 +02:00
Javier Goizueta 4e99ff1c39 Fix token substitution for stat queries 2018-05-18 22:25:32 +02:00
Javier Goizueta 8e8458e557 Merge branch 'master' into metadata 2018-05-18 20:49:26 +02:00
Javier Goizueta 391ac51f0f Implement metadata queries with plain Promises
Remove usage of PhasedExecution
This achives better query execution granularity and
removes questionable usage of shared results object.
It introduces a couple of behavior changes:
* estimatedFeatureCount desn't ignore errors now
* sample always uses estimatedFeatureCount,even if the actual count is also computed.
2018-05-18 15:33:07 +02:00
Javier Goizueta 4bc8fb207a Use sql_raw for query without aggregation 2018-05-18 15:29:46 +02:00
Simon Martín 81bace1dca Merge branch 'master' into fix-dataview-typeof 2018-05-17 12:13:11 +02:00
Javier Goizueta 012fa91e83 Typo 2018-05-16 14:45:34 +02:00
Javier Goizueta 3af1182206 Rename misleading function argument 2018-05-16 14:45:19 +02:00
Simon Martín 04e00bb834 Merge branch 'master' into fix-image-format-png 2018-05-16 14:40:59 +02:00
Simon Martín 56aa1b39f0 removing 'jpeg' as valid format and no checking agains lowercase 2018-05-16 12:00:40 +02:00
Daniel G. Aubert d940ab36e1 Merge pull request #954 from CartoDB/controllers-goodies
Controllers goodies
2018-05-14 18:31:48 +02:00
Daniel García Aubert 5a397afd06 In order to extract common middlewares between routers and controlles we need to activate mergeParams options to preserve the req.params from the parent router 2018-05-14 11:50:48 +02:00
Javier Goizueta 5e09c80b71 Remove comment 2018-05-11 19:57:49 +02:00
Javier Goizueta b906f88a44 Slight refactor 2018-05-11 19:32:03 +02:00
Javier Goizueta 24b1b53ba0 Merge branch 'master' into metadata 2018-05-11 18:58:38 +02:00
Javier Goizueta 53fae9fbbd Comment 2018-05-11 18:57:14 +02:00
Simon Martín ad4ed7a06b detail 2018-05-11 17:47:47 +02:00
Simon Martín 7f5e655730 static image format for last route 2018-05-11 17:45:17 +02:00
Simon Martín e96a9f0b46 static image format controllers 2018-05-11 17:42:28 +02:00
Simon Martín 7112341c51 checkStaticImageFormat middleware 2018-05-11 17:41:00 +02:00
Daniel García Aubert f4d60f963d Add comment 2018-05-11 16:37:02 +02:00
Daniel García Aubert c6babc7dc4 Create .middlewares() method to build midlleware stack to perform request 2018-05-11 16:26:05 +02:00
Daniel García Aubert 3905ed796e Use ES6 class syntax 2018-05-11 16:24:28 +02:00
Daniel García Aubert 595d006d5b Rename function 2018-05-11 16:21:57 +02:00