Javier Goizueta
391ac51f0f
Implement metadata queries with plain Promises
...
Remove usage of PhasedExecution
This achives better query execution granularity and
removes questionable usage of shared results object.
It introduces a couple of behavior changes:
* estimatedFeatureCount desn't ignore errors now
* sample always uses estimatedFeatureCount,even if the actual count is also computed.
2018-05-18 15:33:07 +02:00
Javier Goizueta
b8109401d1
Tests for metadata with aggregation
2018-05-13 13:05:39 +02:00
Javier Goizueta
9818d8bb6c
Merge branch 'master' into cartovl-cartodb_id
2018-04-05 16:02:03 +02:00
Javier Goizueta
f7fad736c3
Add test for uniqueness of aggregated cartodb_id
2018-04-05 16:01:29 +02:00
Javier Goizueta
3d36802686
Tests for columns present in aggregation MVTs
2018-04-04 16:58:11 +02:00
Javier Goizueta
dc706aeb43
Fix bug with dimension aliases
...
The point-sample aggregation query failed if dimensions had alias different from the base columns
2018-04-04 16:29:40 +02:00
Javier Goizueta
6ada8ba6a2
Implement aggregation filters
2018-03-21 17:01:32 +01:00
Javier Goizueta
80604b739a
Add test for aggregation with attributes
...
This reveals #860
2018-01-31 18:56:24 +01:00
Javier Goizueta
debb174af4
Add test for aggregation without the_geom
...
Only the_geom_webmercator is required for aggregation
See #841
2018-01-29 15:44:24 +01:00
Javier Goizueta
7c9b4b7283
Add test to check that cartodb_id is preseent in aggregations
...
See #846
This revealss that point-grid aggregation is missing cartodb_id
2018-01-29 12:40:59 +01:00
Daniel
ee0405da1e
Merge pull request #836 from CartoDB/disable-default-aggregation
...
Add test to check layer aggregation disabling
2018-01-03 13:09:31 +01:00
Daniel García Aubert
1f30367e59
Add test to check layer aggregation disabling
2018-01-03 12:40:00 +01:00
Daniel García Aubert
60005e2f7f
Fix bad assertion
2018-01-03 12:24:07 +01:00
Daniel García Aubert
1c7da2c4b3
Going green: do not fail when map-config is vector-only and a layer doesn't have points
2018-01-03 12:00:25 +01:00
Daniel García Aubert
3799dd2574
Going red: fail when vector only map-config has a polygon layer
2018-01-03 11:14:20 +01:00
Daniel García Aubert
9fbc56b82c
Remove FIXME notes to test against PostGIS vector renderer
2017-12-28 13:13:32 +01:00
Daniel García Aubert
418c8691d1
Support default full-sample aggregation for postgis vector renderer
2017-12-27 20:08:43 +01:00
Javier Goizueta
54f32113f3
Add some aggregation tests
2017-12-22 15:45:34 +01:00
Javier Goizueta
19bf079f2d
Exclude test from PostGIS 2.4
2017-12-22 15:45:14 +01:00
Javier Goizueta
e9a4fc4b2c
Use full-sample aggregation only as default
...
Sampling is performed only when placement, columns or dimensions are specified;
otherwise the regular centroid/grid-point/grid-center is used without sampling.
2017-12-22 11:31:33 +01:00
Daniel García Aubert
7f64d15944
Merge branch 'master' into full-sample
2017-12-20 15:58:58 +01:00
Daniel García Aubert
20366cedb4
Skip test for PostGis 2.4
2017-12-20 14:53:34 +01:00
Daniel García Aubert
a102d1d366
jshint, I hate you
2017-12-20 14:41:29 +01:00
Daniel García Aubert
4b97b4fd26
Fix typo
2017-12-20 14:35:47 +01:00
Daniel García Aubert
4946ca688c
Add test to check full-sample query
2017-12-19 16:17:13 +01:00
Daniel García Aubert
d2828ecaff
Update test
2017-12-19 13:07:57 +01:00
Daniel García Aubert
bdce2f95f2
Add validations for columns
2017-12-18 20:42:26 +01:00
Daniel García Aubert
2dda0a80da
Improve error context
2017-12-18 19:35:12 +01:00
Daniel García Aubert
0bca3d6f33
Validate placement, threshold and resolution
2017-12-18 13:42:27 +01:00
Javier Goizueta
877ed63090
Add tests for the different aggregation placement values
2017-12-15 11:14:17 +01:00
Daniel García Aubert
e4407ece84
Merge branch 'mapconfig-aggregation' of github.com:CartoDB/Windshaft-cartodb into mapconfig-aggregation
2017-12-14 16:39:07 +01:00
Javier Goizueta
753ada0e76
Add cartodb_id to test datasets
2017-12-14 16:36:24 +01:00
Daniel García Aubert
d311dccce8
Add test to check tangram compatibility
2017-12-14 16:35:09 +01:00
Daniel García Aubert
a987f6ac05
Fix issue when the sql has single quotes defined and the aggregation metadata query was not able to estimate row count
2017-12-14 14:14:55 +01:00
Daniel García Aubert
bcfc43a517
jshint, my old friend
2017-12-14 11:22:00 +01:00
Daniel García Aubert
1edf684475
Fix test
2017-12-13 20:04:06 +01:00
Daniel García Aubert
98e8d745b1
Support sql_wrap for aggregation
2017-12-13 17:01:43 +01:00
Daniel García Aubert
e8740af6ef
Fix issue when sql_wrap is provided and aggregation metadata query fails
2017-12-13 16:34:36 +01:00
Daniel García Aubert
6d46a21005
Validate aggregation query param
2017-12-12 19:23:21 +01:00
Daniel García Aubert
869f2ac322
Improve error message
2017-12-12 12:39:12 +01:00
Daniel García Aubert
5bc1903677
Add test to check if cartoccs and aggregation definition are fully compatible
2017-12-12 12:15:13 +01:00
Javier Goizueta
e37682403c
Fix test
...
Note that the CartoCSS should reference columns of the aggregated table
2017-12-12 11:22:10 +01:00
Daniel García Aubert
dab204ea71
Do not aggregate if rows cout is lower than threshold or the layer's sql has geometries distinct of points
2017-12-11 17:32:06 +01:00
Daniel García Aubert
214d684fcc
Adapt layer when is vector only map-caonfig
2017-12-05 20:39:30 +01:00
Daniel García Aubert
9118e2dc5e
Add tests
2017-12-05 20:21:20 +01:00
Daniel García Aubert
e7592ee570
Improve error message
2017-12-05 17:44:52 +01:00
Daniel García Aubert
81d99ca655
Make test to pass
2017-12-05 16:52:15 +01:00
Daniel García Aubert
55dd049812
Be able to skip aggregation to create a layergroup with aggregation defined already
2017-12-05 12:59:32 +01:00
Daniel García Aubert
66b41a6ae7
Now .getLayergroup() in test client accepts params to perform custom instantiations
2017-12-05 12:09:31 +01:00
Daniel García Aubert
855f47e446
Detect incompatible CartoCSS or interactivity for raster aggregation
2017-12-04 19:48:06 +01:00
Javier Goizueta