Commit Graph
1990 Commits
Author SHA1 Message Date
Javier Goizueta fecd63e582 Fix bug 2018-05-21 11:59:49 +02:00
Javier Goizueta 38e55367b1 Revert error behaviour for estimatedFeatureCount
Keep current production behavior of ignoreing errors when computing this stat and returning -1.
This is done as to no introduce any instability in production at the moment.
2018-05-21 11:44:52 +02:00
Javier Goizueta 4e99ff1c39 Fix token substitution for stat queries 2018-05-18 22:25:32 +02:00
Javier Goizueta 8e8458e557 Merge branch 'master' into metadata 2018-05-18 20:49:26 +02:00
Javier Goizueta 391ac51f0f Implement metadata queries with plain Promises
Remove usage of PhasedExecution
This achives better query execution granularity and
removes questionable usage of shared results object.
It introduces a couple of behavior changes:
* estimatedFeatureCount desn't ignore errors now
* sample always uses estimatedFeatureCount,even if the actual count is also computed.
2018-05-18 15:33:07 +02:00
Javier Goizueta 4bc8fb207a Use sql_raw for query without aggregation 2018-05-18 15:29:46 +02:00
Simon Martín 81bace1dca Merge branch 'master' into fix-dataview-typeof 2018-05-17 12:13:11 +02:00
Javier Goizueta 012fa91e83 Typo 2018-05-16 14:45:34 +02:00
Javier Goizueta 3af1182206 Rename misleading function argument 2018-05-16 14:45:19 +02:00
Simon Martín 04e00bb834 Merge branch 'master' into fix-image-format-png 2018-05-16 14:40:59 +02:00
Simon Martín 56aa1b39f0 removing 'jpeg' as valid format and no checking agains lowercase 2018-05-16 12:00:40 +02:00
Daniel G. Aubert d940ab36e1 Merge pull request #954 from CartoDB/controllers-goodies
Controllers goodies
2018-05-14 18:31:48 +02:00
Daniel García Aubert 5a397afd06 In order to extract common middlewares between routers and controlles we need to activate mergeParams options to preserve the req.params from the parent router 2018-05-14 11:50:48 +02:00
Javier Goizueta 5e09c80b71 Remove comment 2018-05-11 19:57:49 +02:00
Javier Goizueta b906f88a44 Slight refactor 2018-05-11 19:32:03 +02:00
Javier Goizueta 24b1b53ba0 Merge branch 'master' into metadata 2018-05-11 18:58:38 +02:00
Javier Goizueta 53fae9fbbd Comment 2018-05-11 18:57:14 +02:00
Simon Martín ad4ed7a06b detail 2018-05-11 17:47:47 +02:00
Simon Martín 7f5e655730 static image format for last route 2018-05-11 17:45:17 +02:00
Simon Martín e96a9f0b46 static image format controllers 2018-05-11 17:42:28 +02:00
Simon Martín 7112341c51 checkStaticImageFormat middleware 2018-05-11 17:41:00 +02:00
Daniel García Aubert f4d60f963d Add comment 2018-05-11 16:37:02 +02:00
Daniel García Aubert c6babc7dc4 Create .middlewares() method to build midlleware stack to perform request 2018-05-11 16:26:05 +02:00
Daniel García Aubert 3905ed796e Use ES6 class syntax 2018-05-11 16:24:28 +02:00
Daniel García Aubert 595d006d5b Rename function 2018-05-11 16:21:57 +02:00
Daniel García Aubert 3bcf6d7ca0 Place comment 2018-05-11 16:20:44 +02:00
Daniel García Aubert 68f5ee7bde Use ES6 class syntax 2018-05-11 16:18:52 +02:00
Daniel García Aubert 9db6e2161b Use ES6 class syntax 2018-05-11 16:15:33 +02:00
Daniel García Aubert 6eeb75a35e Use .middlewares() method to build middleware stack to process the request 2018-05-11 16:13:34 +02:00
Daniel García Aubert 1f717617b0 Add .middlewares() method to build middleware stack to be mounted 2018-05-11 16:07:25 +02:00
Daniel García Aubert 3d7231929c Create .middlewares() method to return the middlewares to process the request 2018-05-11 15:34:10 +02:00
Javier Goizueta 3b4668cc19 Fix simple tabley sampling 2018-05-11 14:45:12 +02:00
Javier Goizueta 34ad3fcfe8 Add aggregated stat for testing
Also change aggregated stats to not filter a single tile
2018-05-11 14:18:31 +02:00
Daniel García Aubert 242224396d Create .middlewares() method to compose controller actions 2018-05-11 14:05:41 +02:00
Javier Goizueta 68b3cb8a34 Fix estimated row count with aggregations
All stats are computed now pre-aggregation
Code to help compute post-aggregation stats remains for testing
2018-05-11 13:44:43 +02:00
Daniel García Aubert 1cfeda8fe5 Create .middlewares() method to mount corresponding set of middlewares 2018-05-11 13:38:51 +02:00
Daniel García Aubert 33af2d37b3 Remove declared variables but not used 2018-05-11 13:30:25 +02:00
Daniel García Aubert 69505974fe Pass object instead of argument list 2018-05-11 13:29:50 +02:00
Daniel García Aubert a77dd9a11f Create .middlewares() method to be mounted in dataview controller 2018-05-11 13:20:05 +02:00
Daniel García Aubert 1bc017eac9 Rename function 2018-05-11 12:42:17 +02:00
Daniel García Aubert 07dec2e641 Create .middlwares() to return a set of middlewares to be mounted 2018-05-11 12:38:52 +02:00
Daniel García Aubert d86a839265 Blank line 2018-05-11 12:22:50 +02:00
Daniel García Aubert 72d8a26ede Use ES6 class 2018-05-11 12:14:27 +02:00
Javier Goizueta cae4dd81c9 WIP: fix problems for aggregations & metadata 2018-05-10 19:12:47 +02:00
Simon Martín eba68c56ef handling pg_typeof undefined 2018-05-10 18:36:08 +02:00
Daniel García Aubert 0741881959 Do not initialize status code to 404 when method is OPTIONS 2018-05-09 16:24:38 +02:00
Daniel García Aubert c51e254287 Set 404 as defautl status code and set the proper status code fir the response at very same time that the response body 2018-05-09 15:00:18 +02:00
Daniel García Aubert 9feea66550 Use routes configuration to create and mount routes and controllers 2018-05-09 14:59:21 +02:00
Javier Goizueta 944ce80c1e Revert debugging change 2018-05-09 11:42:53 +02:00
Javier Goizueta d8ef8cb12f Debug travis test failures 2018-05-09 11:08:02 +02:00