cartodb4/cartodb-postgresql
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Prepend an underscore (_) to functions meant to be run by superuser

Browse Source 
_CDB_SetUp_User_PG_FDW_Server and _CDB_Drop_User_PG_FDW_Server are
meant to be executed by a superuser. Therefore they shouldn't be
considered part of the public API and hence the _CDB_Private_Function
naming convention.
This commit is contained in:
Rafa de la Torre
2019-07-16 14:32:32 +02:00
parent a32dea0282
commit 0f33ee8b22
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
test/extension/test.sh
View File

@@ -607,7 +607,7 @@ test_extension|public|"local-table-with-dashes"'
}
}
EOF
sql postgres "SELECT cartodb.CDB_SetUp_User_PG_FDW_Server('test_user_fdw', '$ufdw_config');"
sql postgres "SELECT cartodb._CDB_SetUp_User_PG_FDW_Server('test_user_fdw', '$ufdw_config');"
# Grant a user access to that FDW, and to grant to others
sql postgres "GRANT test_user_fdw TO cdb_testmember_1 WITH ADMIN OPTION;"
@@ -641,9 +641,9 @@ EOF
sql cdb_testmember_1 "REVOKE test_user_fdw FROM publicuser;"
# If there are dependent objects, we cannot drop the foreign server
sql postgres "SELECT cartodb.CDB_Drop_User_PG_FDW_Server('test_user_fdw')" fails
sql postgres "SELECT cartodb._CDB_Drop_User_PG_FDW_Server('test_user_fdw')" fails
sql cdb_testmember_1 "DROP FOREIGN TABLE test_user_fdw.foo;"
sql postgres "SELECT cartodb.CDB_Drop_User_PG_FDW_Server('test_user_fdw')"
sql postgres "SELECT cartodb._CDB_Drop_User_PG_FDW_Server('test_user_fdw')"
# Teardown