From 3d0f580fc2d5a0dbc27da47ef159aa874d82e89f Mon Sep 17 00:00:00 2001 From: Carla Iriberri Date: Tue, 8 Mar 2016 12:10:46 +0100 Subject: [PATCH] Add idempotence test --- test/CDB_CartodbfyTableTest.sql | 10 +++++++++- test/CDB_CartodbfyTableTest_expect | 6 ++++++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/test/CDB_CartodbfyTableTest.sql b/test/CDB_CartodbfyTableTest.sql index d32f1e8..02c9039 100644 --- a/test/CDB_CartodbfyTableTest.sql +++ b/test/CDB_CartodbfyTableTest.sql @@ -124,13 +124,21 @@ END; $$ LANGUAGE 'plpgsql'; --- table with single non-geometrical column +-- check cartodbfytable idempotence CREATE TABLE t AS SELECT 1::int as a; SELECT CDB_CartodbfyTable('public', 't'); -- should fail SELECT CDB_SetUserQuotaInBytes(0); -- Set user quota to infinite SELECT CDB_CartodbfyTableCheck('t', 'single non-geometrical column'); DROP TABLE t; +-- table with single non-geometrical column +CREATE TABLE t AS SELECT ST_SetSRID(ST_MakePoint(-1,-1),4326) as the_geom, 1::int as cartodb_id, 'this is a sentence' as description; +SELECT CDB_CartodbfyTableCheck('t', 'check function idempotence'); +SELECT * FROM t; +SELECT CDB_CartodbfyTableCheck('t', 'check function idempotence'); +SELECT * FROM t; +DROP TABLE t; + -- table with existing srid-unconstrained (but type-constrained) the_geom CREATE TABLE t AS SELECT ST_SetSRID(ST_MakePoint(0,0),4326)::geometry(point) as the_geom; SELECT CDB_CartodbfyTableCheck('t', 'srid-unconstrained the_geom'); diff --git a/test/CDB_CartodbfyTableTest_expect b/test/CDB_CartodbfyTableTest_expect index b97e9d6..89eb1b9 100644 --- a/test/CDB_CartodbfyTableTest_expect +++ b/test/CDB_CartodbfyTableTest_expect @@ -6,6 +6,12 @@ ERROR: Please set user quota before cartodbfying tables. single non-geometrical column cartodbfied fine DROP TABLE SELECT 1 +check function idempotence cartodbfied fine +1|0101000020E6100000000000000000F0BF000000000000F0BF|0101000020110F0000DB0B4ADA772DFBC046432E49D22DFBC0|this is a sentence +check function idempotence cartodbfied fine +1|0101000020E6100000000000000000F0BF000000000000F0BF|0101000020110F0000DB0B4ADA772DFBC046432E49D22DFBC0|this is a sentence +DROP TABLE +SELECT 1 srid-unconstrained the_geom cartodbfied fine DROP TABLE SELECT 2