cartodb4/cartodb-postgresql
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Third iteration, expect a viable cartodb_id

Browse Source
This commit is contained in:
Carla Iriberri
2016-03-02 14:58:53 +01:00
parent 0d5f83b3c4
commit a18cbeb2cd
1 changed files with 68 additions and 131 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts-available/CDB_CartodbfyTable.sql
+68 -131
View File
@@ -466,33 +466,20 @@ END;
$$ LANGUAGE 'plpgsql'; $$ LANGUAGE 'plpgsql';
DO $$
BEGIN
IF NOT EXISTS (SELECT 1 FROM pg_type WHERE typname = '_cdb_has_usable_primary_id_record') THEN
CREATE TYPE _cdb_has_usable_primary_id_record
AS (has_usable_primary_key boolean,
text_key_column boolean);
END IF;
END$$;
-- Find out if the table already has a usable primary key -- Find out if the table already has a usable primary key
-- If the table has both a usable key and usable geometry -- If the table has both a usable key and usable geometry
-- we can no-op on the table copy and just ensure that the -- we can no-op on the table copy and just ensure that the
-- indexes and triggers are in place -- indexes and triggers are in place
CREATE OR REPLACE FUNCTION cartodb._CDB_Has_Usable_Primary_ID(reloid REGCLASS) CREATE OR REPLACE FUNCTION _CDB_Has_Usable_Primary_ID(reloid REGCLASS)
RETURNS _cdb_has_usable_primary_id_record RETURNS BOOLEAN
AS $$ AS $$
DECLARE DECLARE
rec RECORD; rec RECORD;
const RECORD; const RECORD;
idc RECORD;
i INTEGER; i INTEGER;
sql TEXT; sql TEXT;
useable_key BOOLEAN = false; useable_key BOOLEAN = false;
has_usable_primary_key BOOLEAN = false; has_usable_primary_key BOOLEAN = false;
-- In case cartodb_id is a text column
text_key_column BOOLEAN = false;
BEGIN BEGIN
RAISE DEBUG 'CDB(_CDB_Has_Usable_Primary_ID): %', 'entered function'; RAISE DEBUG 'CDB(_CDB_Has_Usable_Primary_ID): %', 'entered function';
@@ -503,138 +490,96 @@ BEGIN
-- Do we already have a properly named column? -- Do we already have a properly named column?
SELECT a.attname, i.indisprimary, i.indisunique, a.attnotnull, a.atttypid SELECT a.attname, i.indisprimary, i.indisunique, a.attnotnull, a.atttypid
INTO rec INTO rec
FROM pg_class c FROM pg_class c
JOIN pg_attribute a ON a.attrelid = c.oid JOIN pg_attribute a ON a.attrelid = c.oid
JOIN pg_type t ON a.atttypid = t.oid JOIN pg_type t ON a.atttypid = t.oid
LEFT JOIN pg_index i ON c.oid = i.indrelid AND a.attnum = ANY(i.indkey) LEFT JOIN pg_index i ON c.oid = i.indrelid AND a.attnum = ANY(i.indkey)
WHERE c.oid = reloid WHERE c.oid = reloid
AND NOT a.attisdropped AND NOT a.attisdropped
AND a.attname = const.pkey; AND a.attname = const.pkey;
-- Found something named right... -- Found something named right...
IF FOUND THEN IF FOUND THEN
-- And it's an integer or varchar column... -- And it's a unique primary key! Done!
IF rec.atttypid IN (20,21,23,1043) THEN IF (rec.indisprimary OR rec.indisunique) AND rec.attnotnull THEN
RAISE DEBUG 'CDB(_CDB_Has_Usable_Primary_ID): %', Format('found good ''%s''', const.pkey);
RETURN true;
-- And it's a unique primary key! Done! -- Check and see if the column values are unique and not null,
IF (rec.indisprimary OR rec.indisunique) AND rec.attnotnull THEN -- if they are, we can use this column...
RAISE DEBUG 'CDB(_CDB_Has_Usable_Primary_ID): %', Format('found good ''%s''', const.pkey); ELSE
SELECT true as has_usable_primary_key, text_key_column INTO idc;
RETURN idc;
-- Check and see if the column values are unique and not null, -- Assume things are OK until proven otherwise...
-- if they are, we can use this column... useable_key := true;
BEGIN
sql := Format('ALTER TABLE %s ADD CONSTRAINT %s_pk PRIMARY KEY (%s)', reloid::text, const.pkey, const.pkey);
RAISE DEBUG 'CDB(_CDB_Has_Usable_Primary_ID): %', sql;
EXECUTE sql;
EXCEPTION
-- Failed unique check...
WHEN unique_violation THEN
RAISE DEBUG 'CDB(_CDB_Has_Usable_Primary_ID): %', Format('column %s is not unique', const.pkey);
useable_key := false;
-- Failed not null check...
WHEN not_null_violation THEN
RAISE DEBUG 'CDB(_CDB_Has_Usable_Primary_ID): %', Format('column %s contains nulls', const.pkey);
useable_key := false;
-- Other fatal error
WHEN others THEN
PERFORM _CDB_Error(sql, '_CDB_Has_Usable_Primary_ID');
END;
-- Clean up test constraint
IF useable_key THEN
PERFORM _CDB_SQL(Format('ALTER TABLE %s DROP CONSTRAINT %s_pk', reloid::text, const.pkey));
-- Move non-unique column out of the way
ELSE ELSE
-- Assume things are OK until proven otherwise... RAISE DEBUG 'CDB(_CDB_Has_Usable_Primary_ID): %',
useable_key := true; Format('found non-unique ''%s'', renaming it', const.pkey);
-- If the column is varchar, try to cast it to integer PERFORM _CDB_SQL(
IF rec.atttypid IN (1043) THEN Format('ALTER TABLE %s RENAME COLUMN %s TO %I',
RAISE DEBUG 'CDB(_CDB_Has_Usable_Primary_ID): Found text column %', rec.atttypid; reloid::text, rec.attname,
cartodb._CDB_Unique_Column_Identifier(NULL, const.pkey, NULL, reloid)),
BEGIN '_CDB_Has_Usable_Primary_ID');
sql := Format('SELECT %I::integer FROM %s', rec.attname, reloid::text);
RAISE DEBUG 'CDB(_CDB_Has_Usable_Primary_ID): Running %', sql;
EXECUTE sql;
text_key_column := true
EXCEPTION
WHEN invalid_text_representation THEN
RAISE DEBUG 'CDB(_CDB_Has_Usable_Primary_ID): Column % of type text is not a valid integer column', rec.attname;
useable_key := false;
WHEN others THEN
RAISE DEBUG 'CDB(_CDB_Has_Usable_Primary_ID): Exception %', SQLSTATE;
useable_key := false;
END;
END IF;
IF useable_key THEN
BEGIN
sql := Format('ALTER TABLE %s ADD CONSTRAINT %s_pk PRIMARY KEY (%s)', reloid::text, const.pkey, const.pkey);
RAISE DEBUG 'CDB(_CDB_Has_Usable_Primary_ID): %', sql;
EXECUTE sql;
EXCEPTION
-- Failed unique check...
WHEN unique_violation THEN
RAISE DEBUG 'CDB(_CDB_Has_Usable_Primary_ID): %', Format('column %s is not unique', const.pkey);
useable_key := false;
-- Failed not null check...
WHEN not_null_violation THEN
RAISE DEBUG 'CDB(_CDB_Has_Usable_Primary_ID): %', Format('column %s contains nulls', const.pkey);
useable_key := false;
-- Other fatal error
WHEN others THEN
PERFORM _CDB_Error(sql, '_CDB_Has_Usable_Primary_ID');
END;
END IF;
-- Clean up test constraint
IF useable_key THEN
PERFORM _CDB_SQL(Format('ALTER TABLE %s DROP CONSTRAINT %s_pk', reloid::text, const.pkey));
-- Move non-unique column out of the way
ELSE
RAISE DEBUG 'CDB(_CDB_Has_Usable_Primary_ID): %',
Format('found non-unique ''%s'', renaming it', const.pkey);
PERFORM _CDB_SQL(
Format('ALTER TABLE %s RENAME COLUMN %s TO %I',
reloid::text, rec.attname,
cartodb._CDB_Unique_Column_Identifier(NULL, const.pkey, NULL, reloid)),
'_CDB_Has_Usable_Primary_ID');
END IF;
SELECT useable_key as has_usable_primary_key, text_key_column INTO idc;
RETURN idc;
END IF; END IF;
-- It's not an integer column, we have to rename it
ELSE
RAISE DEBUG 'CDB(_CDB_Has_Usable_Primary_ID): %',
Format('found non-integer ''%s'', renaming it', const.pkey);
PERFORM _CDB_SQL( RETURN useable_key;
Format('ALTER TABLE %s RENAME COLUMN %s TO %I',
reloid::text, rec.attname, cartodb._CDB_Unique_Column_Identifier(NULL, const.pkey, NULL, reloid)),
'_CDB_Has_Usable_Primary_ID');
END IF; END IF;
-- There's no column there named pkey -- There's no column there named pkey
ELSE ELSE
-- Is there another suitable primary key already? -- Is there another integer suitable primary key already?
SELECT a.attname SELECT a.attname
INTO rec INTO rec
FROM pg_class c FROM pg_class c
JOIN pg_attribute a ON a.attrelid = c.oid JOIN pg_attribute a ON a.attrelid = c.oid
JOIN pg_type t ON a.atttypid = t.oid JOIN pg_type t ON a.atttypid = t.oid
LEFT JOIN pg_index i ON c.oid = i.indrelid AND a.attnum = ANY(i.indkey) LEFT JOIN pg_index i ON c.oid = i.indrelid AND a.attnum = ANY(i.indkey)
WHERE c.oid = reloid AND NOT a.attisdropped WHERE c.oid = reloid AND NOT a.attisdropped
AND i.indisprimary AND i.indisunique AND a.attnotnull AND a.atttypid IN (20,21,23); AND i.indisprimary AND i.indisunique AND a.attnotnull AND a.atttypid IN (20,21,23);
-- Yes! Ok, rename it. -- Yes! Ok, rename it.
IF FOUND THEN IF FOUND THEN
PERFORM _CDB_SQL(Format('ALTER TABLE %s RENAME COLUMN %s TO %s', reloid::text, rec.attname, const.pkey),'_CDB_Has_Usable_Primary_ID'); PERFORM _CDB_SQL(Format('ALTER TABLE %s RENAME COLUMN %s TO %s', reloid::text, rec.attname, const.pkey),'_CDB_Has_Usable_Primary_ID');
SELECT true as has_usable_primary_key, text_key_column INTO idc; RETURN true;
RETURN idc;
ELSE ELSE
RAISE DEBUG 'CDB(_CDB_Has_Usable_Primary_ID): %', RAISE DEBUG 'CDB(_CDB_Has_Usable_Primary_ID): %',
Format('found no useful column for ''%s''', const.pkey); Format('found no useful column for ''%s''', const.pkey);
END IF; END IF;
END IF; END IF;
RAISE DEBUG 'CDB(_CDB_Has_Usable_Primary_ID): %', 'function complete'; RAISE DEBUG 'CDB(_CDB_Has_Usable_Primary_ID): %', 'function complete';
-- Didn't find re-usable key, so return FALSE -- Didn't find re-usable key, so return FALSE
SELECT false as has_usable_primary_key, text_key_column INTO idc; RETURN false;
RETURN idc;
END; END;
$$ LANGUAGE 'plpgsql'; $$ LANGUAGE 'plpgsql';
@@ -837,7 +782,7 @@ $$ LANGUAGE 'plpgsql';
-- a "good" one, and the same for the geometry columns. If all the required -- a "good" one, and the same for the geometry columns. If all the required
-- columns are in place already, it no-ops and just renames the table to -- columns are in place already, it no-ops and just renames the table to
-- the destination if necessary. -- the destination if necessary.
CREATE OR REPLACE FUNCTION cartodb._CDB_Rewrite_Table(reloid REGCLASS, destschema TEXT DEFAULT NULL) CREATE OR REPLACE FUNCTION _CDB_Rewrite_Table(reloid REGCLASS, destschema TEXT DEFAULT NULL)
RETURNS BOOLEAN RETURNS BOOLEAN
AS $$ AS $$
DECLARE DECLARE
@@ -858,15 +803,15 @@ DECLARE
rec RECORD; rec RECORD;
const RECORD; const RECORD;
idc RECORD;
gc RECORD; gc RECORD;
sql TEXT; sql TEXT;
str TEXT; str TEXT;
table_srid INTEGER; table_srid INTEGER;
geom_srid INTEGER; geom_srid INTEGER;
has_usable_primary_key BOOLEAN;
has_usable_pk_sequence BOOLEAN; has_usable_pk_sequence BOOLEAN;
BEGIN BEGIN
RAISE DEBUG 'CDB(_CDB_Rewrite_Table): %', 'entered function'; RAISE DEBUG 'CDB(_CDB_Rewrite_Table): %', 'entered function';
@@ -877,7 +822,7 @@ BEGIN
-- Save the raw schema/table names for later -- Save the raw schema/table names for later
SELECT n.nspname, c.relname, c.relname SELECT n.nspname, c.relname, c.relname
INTO STRICT relschema, relname, destname INTO STRICT relschema, relname, destname
FROM pg_class c JOIN pg_namespace n ON c.relnamespace = n.oid FROM pg_class c JOIN pg_namespace n ON c.relnamespace = n.oid
WHERE c.oid = reloid; WHERE c.oid = reloid;
-- Default the destination to current schema if unspecified -- Default the destination to current schema if unspecified
@@ -888,16 +833,15 @@ BEGIN
-- See if there is a primary key column we need to carry along to the -- See if there is a primary key column we need to carry along to the
-- new table. If this is true, it implies there is an indexed -- new table. If this is true, it implies there is an indexed
-- primary key of integer type named (by default) cartodb_id -- primary key of integer type named (by default) cartodb_id
SELECT has_usable_primary_key, text_key_column SELECT _CDB_Has_Usable_Primary_ID(reloid)
FROM _CDB_Has_Usable_Primary_ID(reloid) INTO STRICT has_usable_primary_key;
INTO STRICT idc;
RAISE DEBUG 'CDB(_CDB_Rewrite_Table): has_usable_primary_key %', idc.has_usable_primary_key; RAISE DEBUG 'CDB(_CDB_Rewrite_Table): has_usable_primary_key %', has_usable_primary_key;
-- See if the candidate primary key column has a sequence for default -- See if the candidate primary key column has a sequence for default
-- values. No usable pk implies has_usable_pk_sequence = false. -- values. No usable pk implies has_usable_pk_sequence = false.
has_usable_pk_sequence := false; has_usable_pk_sequence := false;
IF idc.has_usable_primary_key THEN IF has_usable_primary_key THEN
SELECT _CDB_Has_Usable_PK_Sequence(reloid) SELECT _CDB_Has_Usable_PK_Sequence(reloid)
INTO STRICT has_usable_pk_sequence; INTO STRICT has_usable_pk_sequence;
END IF; END IF;
@@ -929,19 +873,12 @@ BEGIN
RAISE DEBUG 'CDB(_CDB_Rewrite_Table): has_usable_geoms %', gc.has_usable_geoms; RAISE DEBUG 'CDB(_CDB_Rewrite_Table): has_usable_geoms %', gc.has_usable_geoms;
-- We can only avoid a rewrite if both the key and -- We can only avoid a rewrite if both the key and
-- geometry are usable -- geometry are usable
-- If cartodb_id column is of type text, cast it
IF idc.text_key_column THEN
sql := Format('ALTER TABLE %s ALTER cartodb_id TYPE int USING %I::integer', reloid::text, 'cartodb_id');
PERFORM _CDB_SQL(sql,'_CDB_Rewrite_Table');
END IF;
RAISE DEBUG 'idc %', idc;
-- No table re-write is required, BUT a rename is required to -- No table re-write is required, BUT a rename is required to
-- a destination schema, so do that now -- a destination schema, so do that now
IF idc.has_usable_primary_key AND has_usable_pk_sequence AND gc.has_usable_geoms THEN IF has_usable_primary_key AND has_usable_pk_sequence AND gc.has_usable_geoms THEN
IF destschema != relschema THEN IF destschema != relschema THEN
RAISE DEBUG 'CDB(_CDB_Rewrite_Table): perfect table needs to be moved to schema (%)', destschema; RAISE DEBUG 'CDB(_CDB_Rewrite_Table): perfect table needs to be moved to schema (%)', destschema;
@@ -979,8 +916,8 @@ BEGIN
sql := Format('CREATE TABLE %s AS SELECT ', copyname); sql := Format('CREATE TABLE %s AS SELECT ', copyname);
-- Add cartodb ID! -- Add cartodb ID!
IF idc.has_usable_primary_key THEN IF has_usable_primary_key THEN
sql := sql || const.pkey; sql := sql || const.pkey || '::bigint ';
ELSE ELSE
sql := sql || 'nextval(''' || destseq || ''') AS ' || const.pkey; sql := sql || 'nextval(''' || destseq || ''') AS ' || const.pkey;
END IF; END IF;