From 2f8dbbb5dc31e2c59f98593799843d0cce7a765c Mon Sep 17 00:00:00 2001 From: Mario de Frutos Date: Wed, 31 Jan 2018 12:16:13 +0100 Subject: [PATCH] Dont raise exception when empty params passed to HERE geocoder --- .../python/cartodb_services/cartodb_services/here/geocoder.py | 2 +- .../lib/python/cartodb_services/test/test_heremapsgeocoder.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/server/lib/python/cartodb_services/cartodb_services/here/geocoder.py b/server/lib/python/cartodb_services/cartodb_services/here/geocoder.py index 6cd0a7b..29166c6 100644 --- a/server/lib/python/cartodb_services/cartodb_services/here/geocoder.py +++ b/server/lib/python/cartodb_services/cartodb_services/here/geocoder.py @@ -70,7 +70,7 @@ class HereMapsGeocoder(Traceable): if value: params[key] = value if not params: - raise NoGeocodingParams() + return [] return self._execute_geocode(params) def _execute_geocode(self, params): diff --git a/server/lib/python/cartodb_services/test/test_heremapsgeocoder.py b/server/lib/python/cartodb_services/test/test_heremapsgeocoder.py index daf813d..4cdaef5 100644 --- a/server/lib/python/cartodb_services/test/test_heremapsgeocoder.py +++ b/server/lib/python/cartodb_services/test/test_heremapsgeocoder.py @@ -128,8 +128,8 @@ class HereMapsGeocoderTestCase(unittest.TestCase): def test_geocode_address_with_no_params(self, req_mock): req_mock.register_uri('GET', HereMapsGeocoder.PRODUCTION_GEOCODE_JSON_URL, text=self.GOOD_RESPONSE) - with self.assertRaises(NoGeocodingParams): - self.geocoder.geocode() + result = self.geocoder.geocode() + self.assertEqual(result, []) def test_geocode_address_empty_response(self, req_mock): req_mock.register_uri('GET', HereMapsGeocoder.PRODUCTION_GEOCODE_JSON_URL,