Fix for crash when sentinel_master_id is absent in config

This commit is contained in:
Rafa de la Torre
2016-10-06 15:04:25 +02:00
parent 00e6cace76
commit 6d0ad85d48
2 changed files with 17 additions and 3 deletions

View File

@@ -99,3 +99,17 @@ class TestRedisMetricsConnectionConfigBuilder(TestCase):
assert config.timeout == 0.2
assert config.db == 3
assert config.sentinel_id == 'some_master_id'
def test_it_sets_absent_values_to_none_or_defaults(self):
server_config_storage = InMemoryConfigStorage({
'redis_metrics_config': {
'redis_host': 'myhost.com',
'redis_port': 6379,
}
})
config = RedisMetricsConnectionConfigBuilder(server_config_storage).get()
assert config.host == 'myhost.com'
assert config.port == 6379
assert config.timeout == 1.5
assert config.db == 5
assert config.sentinel_id is None