From 87bb8bea68c05b69d45d7700e66a499ebf9bb4a5 Mon Sep 17 00:00:00 2001 From: Mario de Frutos Date: Mon, 19 Nov 2018 17:59:47 +0100 Subject: [PATCH] Remove duped metrics for isochrones We are counting the success/empty inside the iteration of the results returned by the third party service. For example, if we ask for 3 isochrones to a provider we count: - 1 for success or empty - If success we add 1 more success for each isochrone in the result - N isolines_generated but it should be - 1 for success or empty - N isolines_generated --- server/extension/sql/80_isolines_helper.sql | 6 ------ 1 file changed, 6 deletions(-) diff --git a/server/extension/sql/80_isolines_helper.sql b/server/extension/sql/80_isolines_helper.sql index b0bd598..ade6b65 100644 --- a/server/extension/sql/80_isolines_helper.sql +++ b/server/extension/sql/80_isolines_helper.sql @@ -295,10 +295,8 @@ RETURNS SETOF cdb_dataservices_server.isoline AS $$ for isochrone in resp: result_polygon = coordinates_to_polygon(isochrone.coordinates) if result_polygon: - quota_service.increment_success_service_use() result.append([source, isochrone.duration, result_polygon]) else: - quota_service.increment_empty_service_use() result.append([source, isochrone.duration, None]) quota_service.increment_success_service_use() quota_service.increment_isolines_service_use(len(result)) @@ -356,10 +354,8 @@ RETURNS SETOF cdb_dataservices_server.isoline AS $$ for isochrone in resp: result_polygon = coordinates_to_polygon(isochrone.coordinates) if result_polygon: - service_manager.quota_service.increment_success_service_use() result.append([source, isochrone.duration, result_polygon]) else: - service_manager.quota_service.increment_empty_service_use() result.append([source, isochrone.duration, None]) service_manager.quota_service.increment_success_service_use() service_manager.quota_service.increment_isolines_service_use(len(result)) @@ -416,10 +412,8 @@ RETURNS SETOF cdb_dataservices_server.isoline AS $$ for isochrone in resp: result_polygon = coordinates_to_polygon(isochrone.coordinates) if result_polygon: - service_manager.quota_service.increment_success_service_use() result.append([source, isochrone.duration, result_polygon]) else: - service_manager.quota_service.increment_empty_service_use() result.append([source, isochrone.duration, None]) service_manager.quota_service.increment_success_service_use() service_manager.quota_service.increment_isolines_service_use(len(result))